Skip to content

fix(finance): extend product master list sort keys and multi-type filter - #46

Merged
ilramdhan merged 1 commit into
mutugading:mainfrom
ilramdhan:feat/rbac-page-scoped-permissions
Jul 2, 2026
Merged

fix(finance): extend product master list sort keys and multi-type filter#46
ilramdhan merged 1 commit into
mutugading:mainfrom
ilramdhan:feat/rbac-page-scoped-permissions

Conversation

@ilramdhan

Copy link
Copy Markdown
Member

Description

Pull request ini berisi penambahan fitur pada API product master list di layanan Finance. Pembaruan ini mencakup perluasan dukungan parameter pengurutan (sorting), dukungan filter multi-tipe untuk ID produk, serta peningkatan fungsi pencarian agar mencakup Oracle System ID.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that changes existing functionality)
  • 📚 Documentation update
  • 🔧 Chore (maintenance, dependencies, etc.)
  • 🚨 Hotfix (urgent production fix)

Changes Made

  • Memperluas validasi parameter sort_by menjadi 12 nilai dengan menambahkan: updated_at, product_type_code, shade_code, grade_code, oracle_sys_id, erp_compound_key, type_label, dan status.
  • Menambahkan parameter product_type_ids (repeated int32) untuk filter multi-tipe yang digabungkan (unioned) dengan product_type_id versi legacy.
  • Memperbarui fungsi pencarian (search) agar kueri pencarian sekarang juga dapat mencocokkan Oracle sys ID (flex_02).

Related Issues

Fixes #
Related to #

Testing Performed

  • Kustomize build passes (kustomize build <path>)
  • YAML lint passes (yamllint .)
  • kubectl dry-run passes (if applicable)
  • Tested on local cluster (if applicable)

Staging Verification (required for production changes)

  • Deployed to staging
  • Verified functionality for 24+ hours
  • No alerts triggered
  • Logs checked for errors

Rollback Plan

  • Revert commit ini untuk mengembalikan fungsi API product master list (filter, sort, dan search) ke versi sebelumnya jika terjadi kendala pada kueri database atau integrasi frontend.

Documentation

  • README.md updated (if needed)
  • RULES.md updated (if needed)
  • Runbook created/updated (if needed)

Screenshots (if applicable)


Pre-merge Checklist

  • I have read and followed RULES.md
  • I have read and followed CONTRIBUTING.md
  • No secrets are committed
  • PR description is complete and clear
  • CI checks are passing

- Widen sort_by validation to 12 values (adds updated_at, product_type_code,
  shade_code, grade_code, oracle_sys_id, erp_compound_key, type_label, status)
- Add repeated int32 product_type_ids (unioned with legacy product_type_id)
- Search now also matches oracle sys id (flex_02)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ilramdhan ilramdhan self-assigned this Jul 2, 2026
Copilot AI review requested due to automatic review settings July 2, 2026 09:34
@ilramdhan ilramdhan added bug Something isn't working enhancement New feature or request fix labels Jul 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ilramdhan ilramdhan moved this from Todo to In progress in Goapps Roadmap [Shared-Proto] Jul 2, 2026
@ilramdhan ilramdhan added this to the Costing Release Milestone milestone Jul 2, 2026
@ilramdhan
ilramdhan merged commit bde02d2 into mutugading:main Jul 2, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Goapps Roadmap [Shared-Proto] Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request fix

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants