fix(finance): extend product master list sort keys and multi-type filter - #46
Merged
ilramdhan merged 1 commit intoJul 2, 2026
Merged
Conversation
- Widen sort_by validation to 12 values (adds updated_at, product_type_code, shade_code, grade_code, oracle_sys_id, erp_compound_key, type_label, status) - Add repeated int32 product_type_ids (unioned with legacy product_type_id) - Search now also matches oracle sys id (flex_02) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pull request ini berisi penambahan fitur pada API product master list di layanan Finance. Pembaruan ini mencakup perluasan dukungan parameter pengurutan (sorting), dukungan filter multi-tipe untuk ID produk, serta peningkatan fungsi pencarian agar mencakup Oracle System ID.
Type of Change
Changes Made
sort_bymenjadi 12 nilai dengan menambahkan:updated_at,product_type_code,shade_code,grade_code,oracle_sys_id,erp_compound_key,type_label, danstatus.product_type_ids(repeated int32) untuk filter multi-tipe yang digabungkan (unioned) denganproduct_type_idversi legacy.flex_02).Related Issues
Fixes #
Related to #
Testing Performed
kustomize build <path>)yamllint .)Staging Verification (required for production changes)
Rollback Plan
Documentation
Screenshots (if applicable)
Pre-merge Checklist