Repository navigation
CI: use the release and checksum scripts from muse - #35426
luapmartin wants to merge 3 commits into
Conversation
MuseScore's copy of make_tag_name.sh was identical to the framework's at the pinned revision. The script runs cmake -P version.cmake and git tag in the working directory, so calling it from muse/ changes nothing. Step 3 of audacity/audacity#12542. Assisted-by: Claude Code 2.1.312
An identical copy. The script works on build.artifacts/ and release/ in the working directory, so calling it from muse/ changes nothing. Step 3 of audacity/audacity#12542. Assisted-by: Claude Code 2.1.312
An identical copy, called after packaging in the four build workflows. The script works on build.artifacts/ in the working directory, so calling it from muse/ changes nothing. Step 3 of audacity/audacity#12542. Assisted-by: Claude Code 2.1.312
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly describes the main change: CI now uses the release and checksum scripts from the framework copy in muse. |
| Description check | |
The description explains the motivation and scope, identifies the external issue, completes the required checklist, and documents AI assistance. It also states the testing performed and why no unit te… |
| Docstring Coverage | |
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description explains the motivation and scope, identifies the external issue, completes the required checklist, and documents AI assistance. It also states the testing performed and why no unit test or vtest was added.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
shoogle
left a comment
shoogle
left a comment
There was a problem hiding this comment.
Thanks! Since the changes are very similar, please squash to 1 commit before merging. (e.g. via GitHub's "Squash and merge" option).
Resolves: step 3 of audacity/audacity#12542 (no MuseScore issue)
Call the framework's copies of
make_tag_name.sh,collate_release_binaries.shandchecksum.shfrommuse/and drop ours, as done before for the S3, ccache, coverage and learn-playlist scripts. The three copies are byte-identical at the pinned framework revision, and the scripts work on the working directory (version.cmake,git tag,build.artifacts/,release/), so nothing changes in what the workflows do.musescore/muse_framework#391 then makes those scripts take the app's tag format as parameters, with MuseScore's values as defaults; MuseScore picks that up with its next framework bump without further changes here.
AI assistance: Claude Code 2.1.312 (see the
Assisted-by:trailers).Complete only if applicable:
Claude Code 2.1.312