Repository navigation
Fix SMB playback and library scan reliability - #361
Merged
ultraelectronica merged 5 commits intoNov 6, 2026
Merged
ultraelectronica merged 5 commits into
ultraelectronica merged 5 commits into
Conversation
Harden USB DAC volume safety and add ISO completion diagnostics
Complete SMB playback hardening with atomic cache handling and safe failure reporting
Release 0.23.1-beta.3
Add adaptive landscape layouts, playback customization, SAF metadata writes, and DSP telemetry
adithya-s-119
force-pushed
the
fix/smb-playback-reliability
branch
from
November 5, 2026 21:18
b88c39e to
c574e1b
Compare
- Skip unreadable or vanished child directories during the SMB walk instead of aborting the whole sync; de-duplicate paths and cap recursion depth. - Read cover art with the pipelined SMB reader so images above the server's single-READ limit load. - Enable SMB auto-reconnect and allow a longer initial connect timeout. - Isolate progress callbacks from the shared transfer, release the coalescing entry when the transfer finishes, and treat a vanished cache file as a miss. - Invalidate cached bytes when a resync sees a changed file size. - Normalize or derive the cache extension, and catch failed next-track preparation instead of letting an unawaited task throw.
Member
|
Will be reviewed @adithya-s-119, thanks a lot for contributing! |
ultraelectronica
approved these changes
Nov 6, 2026
ultraelectronica
left a comment
Member
There was a problem hiding this comment.
Approved after local verification on Linux: flutter analyze --no-fatal-infos (28 pre-existing infos, no errors/warnings), targeted SMB/network tests (38 passed), full cargo test --lib (368 passed), and build_runner generated no stale outputs. The full Flutter suite has two unrelated pre-existing/local failures (webdav_sync_integration_test Isar Core version mismatch and a flaky Apple Music run). Changes match the existing SMB failure-handling and cache patterns.
5 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several SMB playback and library-sync failure modes, with the unreachable/unreadable child-directory scan bug as the main one.
System Volume Informationthat even a valid account cannot list. The BFS previously failed the entire scan there, which could leave a fresh SMB library empty and make playback look broken. Child directories that are denied, missing, or unsupported are now skipped; failure to list the configured root still fails loudly. Directory paths are de-duplicated and recursion depth is capped to stop junction/DFS loops.read_fileis a single READ and fails withFileTooLargeForSingleReadabove the server'sMaxReadSize(as small as 64 KiB on some NAS firmware). Folder art now loads on those servers.FLAC,flac, or no hint share one file.ClientConfigwith auto-reconnect and a 15-second initial connect timeout instead of the 5-second, no-reconnect shorthand.Related issue
Refs #291 (SMB playback). Does not claim to close it until the reporter can retest on the original Windows share.
Testing
flutter analyze --no-fatal-infos: no errors or warnings (28 pre-existing infos, unchanged frommain).flutter test test/services/smb_service_parse_test.dart test/services/smb_service_download_test.dart test/services/network_cache_service_test.dart test/services/remote_metadata_backfill_test.dart: 38 passed, including new coverage for throwing progress callbacks, extension normalization/derivation, and cache invalidation.cargo test --libcannot run on this Windows host because the existingsoundtouch-sysC++ build fails under the local GNU toolchain. I compiled the exactsmb_api.rsin an isolated crate againstsmb2 0.27.2and ran its tests: 7 passed (including the new child-directory/root distinction and client-config tests). CI's Linuxcargo test --libremains the authoritative full run.flutter teston this Windows host has pre-existing failures (layout overflows and platform-specific HTTP/cache tests). I confirmed the same failures on a cleanmaincheckout; the SMB suite passes.Checklist
flutter analyzepassesflutter testpasses (SMB/network suites pass; full Windows run has pre-existing failures)cargo test --manifest-path rust/Cargo.tomlpasses (SMB module tests pass in isolation; full run blocked by existing soundtouch build issue on this host)CHANGELOG.mdupdated for user-facing changes