Repository navigation
Support SMB domain accounts and partial syncs - #363
Merged
ultraelectronica merged 1 commit intoNov 7, 2026
Merged
ultraelectronica merged 1 commit into
ultraelectronica merged 1 commit into
Conversation
- Split DOMAIN\\user and user@domain usernames into the account and domain fields NTLM expects. - Keep songs already listed when an SMB walk is interrupted, skip the stale-row purge and lastSyncedAt stamp, then surface the scan failure so a later sync can finish. - Document the account formats and interrupted-sync behavior.
ultraelectronica
approved these changes
Nov 7, 2026
ultraelectronica
left a comment
Member
There was a problem hiding this comment.
Reviewed and approved for versionF testing.
- Rust:
split_accountis unit-tested for plain, DOMAIN\user, user@domain, and malformed inputs; all 8 SMB tests and the full 369-test host suite pass. - Dart: partial walks import collected entries before rethrowing, and skip purge/lastSyncedAt so unseen files are not treated as stale. Targeted SMB/cache/backfill suites pass (38 tests).
- CI: all checks green (4 Android Rust targets, host Rust tests, Flutter analyze + test).
- Local full Flutter run: 1222 passed; only
webdav_sync_integration_test.dartfailed to load due to a pre-existing local Isar Core version mismatch (required 3.3.2, found 3.4.1), unrelated to this PR. - Hardware SMB validation (especially domain/UPN accounts) still pending; that is what versionF is for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #361. Two remaining SMB problems:
smb2passes the account name and domain to NTLM separately, but Flick only has one username field and was sendingDOMAIN\user(oruser@domain) as the account with an empty domain. Those forms are now split into the pieces a Windows client sends. Plain local usernames are unchanged.Behavior now
lastSyncedAt(unchanged).lastSyncedAtstamp (unseen files are not stale), log an allowlistedresult=partialrecord, and still surface the scan failure so the user can retry and complete it.DOMAIN\user,user@domain, plain user, guest, and malformed separator input are covered by Rust unit tests.Related issue
Refs #291.
Testing
flutter analyze --no-fatal-infos: no errors or warnings (same 28 pre-existing infos asmain).flutter test test/services/smb_service_parse_test.dart test/services/smb_service_download_test.dart test/services/network_cache_service_test.dart test/services/remote_metadata_backfill_test.dart: 38 passed.smb2 0.27.2: 8 passed, including the new account-format tests. Fullcargo testis blocked on this Windows host by the existingsoundtouch-sysC++ build issue.Checklist
flutter analyzepassesflutter testpasses (SMB/network suites pass; full Windows run has pre-existing failures)cargo test --manifest-path rust/Cargo.tomlpasses (SMB module tests pass in isolation; full run blocked by existing soundtouch build issue on this host)CHANGELOG.mdupdated for user-facing changes