Repository navigation
quest(m1): plan #4349 follow-ups after the reporter's re-run #5325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kixelated
merged 3 commits into
main
from
claude/cross-node-broadcast-retraction-6e48b7
Oct 11, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # [M] Reproduce cross-node announce flapping | ||
|
|
||
| ## Goal | ||
|
|
||
| A time-mocked drill with three or more clustered relays, extending | ||
| `rs/moq-net/tests/mesh_withdraw.rs` (which already checks one retraction on a | ||
| 34-node partial mesh) or added beside it: a publisher on one node cleanly closes a broadcast, and a client | ||
| watching its prefix on another node sees one retraction, with no | ||
| re-announce, for that path. The drill runs against `main` and lands as a | ||
| regression test. | ||
|
|
||
| Reported in [#4349](https://github.com/moq-dev/moq/issues/4349) against the | ||
| release on cdn.moq.pro (2026-10-11): after a clean close, the subscriber's | ||
| announce stream saw the path Announced/Retracted about 1140 times over about | ||
| 2 s, and subscribes meanwhile answered `internal error` or `unroutable`. | ||
| It never happened on one node or on a self-hosted two-relay 0.17.2 cluster. | ||
| Loss and FETCH were clean in every run (about 31k FETCHes, all ok). | ||
|
|
||
| ## Plan | ||
|
|
||
| - Decided 2026-10-11: `main` likely already handles this (the report ran on | ||
| the release), so reproduce before fixing. Run the drill on the | ||
| `moq-relay-v0.17.2` tree too, to confirm it catches the reported toggling; | ||
| a passing `main` drill counts as evidence only after that positive control | ||
| fails on the release. | ||
| - Suspected mechanism, unconfirmed: path hunting in today's lite-06 path | ||
| vector. A peer's re-announce of a withdrawn prefix clears its withdrawal | ||
| (`reannounced` in `rs/moq-net/src/model/origin.rs`) and revives stale | ||
| alternate routes through it, so each node's late withdrawal toggles the | ||
| path again. A two-relay cluster has no alternates, which fits the report. | ||
| #4642's 300 ms hold does not cover it: it delays only updates to a | ||
| prefix already delivered, and each toggle is a fresh retract or announce. | ||
| - If `main` is clean, land the drill and close #4349 asking the reporter to | ||
| re-run once the next release reaches cdn.moq.pro. If `main` still flaps, | ||
| fix it at the source in the path vector when the fix is small; otherwise | ||
| land the drill as an acceptance test for | ||
| [Routes and announces](/quest/m1/cluster-routing/routes.md), keep #4349 | ||
| open, and move this `Closes` entry there. | ||
| - Not planned here: the reporter's self-hosted two-relay rejoin stall | ||
| (`subscribe canceled (idle)`, then `old`, then no state). On 0.17.2 a | ||
| rejoin could read a stale cached group as the live edge, which #4741 and | ||
| #4914 changed on `main`; revisit it if their re-run on a release | ||
| carrying those still stalls. | ||
| - Harness for reference: https://github.com/fperex/moq-burst-repro (published | ||
| crates only); its traces hold per-session announcement sequences. | ||
|
|
||
| ## Closes | ||
|
|
||
| - [#4349](https://github.com/moq-dev/moq/issues/4349) - close this issue when the quest finishes | ||
|
|
||
| ## Related | ||
|
|
||
| - [Routes and announces](/quest/m1/cluster-routing/routes.md) - the lite-07 redesign that ends path hunting by construction | ||
| - [Dropped sources](/quest/m1/dropped-sources.md) - the `internal error` replies seen during the same churn | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Keep
#4349open until the release is verified.If the drill passes on
main, this plan closes#4349before the reporter verifies a release oncdn.moq.pro. Keep the issue open until that rerun confirms the reported behavior is resolved.🤖 Prompt for AI Agents