Repository navigation
quest: plan the Interop latecomer control and TS PSI runs #5271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+59
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # [S] Interop's lagging latecomer control fails as designed | ||
|
|
||
| ## Goal | ||
|
|
||
| Interop's "control: lagging latecomer" negative control reliably fails | ||
| "late join reaches live", so a passing positive case means something. A | ||
| failing Interop step no longer hides the steps after it: the TS steps run | ||
| and report on their own whatever the browser media step did. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found on #5207 (2026-10-10). The control (`test/interop/interop.sh`, added in | ||
| #5173) runs `test/interop/clients/js/media.ts --lag --cases late-join | ||
| --expect-fail "late join reaches live"`. In 3 of 4 runs on #5207, and on | ||
| unrelated PRs, the lagged latecomer still reached live, so the control | ||
| failed. Because the media step fails first, CI skips every TS Interop step, | ||
| so TS regressions can land with no CI signal (the `--headroom` arm added in | ||
| #5207 has not run in CI yet). | ||
|
|
||
| - Find why `--lag` doesn't keep the player behind `LIVE_LAG_FRAMES` (the | ||
| player may catch up, the delay may not apply, or live detection may be too | ||
| loose), and fix that at its cause. Never widen thresholds, add retries, or | ||
| lengthen timeouts. | ||
| - Decided (2026-10-10): in this quest, make the Interop steps independent, so | ||
| one red step never skips another. The job still fails if any step fails. | ||
|
|
||
| Public API: none. Wire: none. | ||
|
|
||
| ## Related | ||
|
|
||
| - [TS duration fidelity](/quest/m0/ts-duration-fidelity.md) - the other failure that keeps Interop red on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # [S] A TS slot never repeats a PSI run back to back | ||
|
|
||
| ## Goal | ||
|
|
||
| When keyframes on several video PIDs align in one slot, the export does not | ||
| lay identical PAT and PMT runs back to back, so the system buffer (512 bytes, | ||
| ISO 13818-1 2.4.2.3) never overflows at 25 Mb/s and up. Each send-ahead unit | ||
| still leads with its own tables as a tune-in point, and changed tables (a new | ||
| PMT version) always go out, in order. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found by Codex on #5207 (`schedule.rs`, repeated PSI groups). It exists on | ||
| `main` before #5207 too. Keeping each table once per slot was tried and broke | ||
| `aac_program_config_follows_each_table`, because send-ahead units need their | ||
| own tables. | ||
|
|
||
| - Start from the author's narrower diff on #5207 | ||
| (https://github.com/moq-dev/moq/pull/5207#discussion_r4239051134): drop a run | ||
| only when the same flush would lay it right after an identical run, and pad | ||
| the dropped packets back with nulls in a padded slot. | ||
| - Test against system-buffer fill with the T-STD model, not a packet count: | ||
| three or more aligned video keyframes at 25 Mb/s overflow today, and pass | ||
| after the fix. The AAC tune-in test still passes. | ||
|
|
||
| Public API: none. Wire: none. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.