Skip to content

quest: drop Required links to quests #5138 and #5141 finished - #5177

Merged
kixelated merged 1 commit into
mainfrom
quest/fix-dangling-required
Oct 10, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/fix-dangling-required

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

quest check fails on main. #5168 added Required entries to quest/m1/webgpu-safari.md and quest/m1/js-restart-keeps-request.md that pointed at webgpu-renderer.md and dynamic-epoch.md. #5138 and #5141 then merged and deleted those quests without removing the entries. Both blockers are done, so this drops the two Required sections, which unblocks both quests.

This breaks the Quest check on every open PR, so it should land quickly.

Public API: none. Wire: none.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T05:03:23.222251Z 8e2695d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a2f33b34-8c1c-4afb-9b38-76b195f016d3

📥 Commits

Reviewing files that changed from the base of the PR and between c39780f and 8e2695d.


📒 Files selected for processing (2)
  • quest/m1/js-restart-keeps-request.md
  • quest/m1/webgpu-safari.md

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Automated review of 8e2695d7

Docs-only fix: removes the two Required sections in quest/m1/js-restart-keeps-request.md and quest/m1/webgpu-safari.md whose targets were deleted when #5138 and #5141 merged.

Verified: both #5138 and #5141 are merged, and quest/m1/webgpu-renderer.md and quest/m0/broadcast-epoch/dynamic-epoch.md no longer exist on main, so the links were dead and the blockers are genuinely done. The ## Related section in webgpu-safari.md is left intact.

No blocking issues.

Non-blocking:

Verdict: MERGE (once the Quest check is green)

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 8e2695d

No actionable bugs found in the full two-file diff. Removing the completed prerequisites is the simplest appropriate fix: #5138 and #5141 are merged and deleted the referenced quests, while both follow-up plans and the Safari quest's Related link remain intact. This agrees with the existing review's dependency assessment.

Verification: inspected both complete quest files and the prerequisite PR metadata/deletion patches. Static review only; I did not run quest check or tests.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging. main is unchanged since this branch (base c39780f9), quest check passes locally on 8e2695d7 (430 documents ok), and no other quest references the deleted paths. Check, Test, and Quest are green. Codex gave a thumbs-up and the OpenAI automated review found nothing actionable. No decisions or follow-ups.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit d224550 into main Oct 10, 2026
5 checks passed
@kixelated
kixelated deleted the quest/fix-dangling-required branch October 10, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant