Skip to content

fix(deps): bump moq-noq to 1.3.4 on release - #5072

Merged
kixelated merged 2 commits into
releasefrom
quest/m0/release-22/noq
Oct 9, 2026
Merged

kixelated merged 2 commits into
releasefrom
quest/m0/release-22/noq

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

On release, web-transport-moq 1.3.3 panics when a raw QUIC peer without datagram support asks for the max datagram size. This blocks draft-22 interop on the 0.17 line (quest quest/m0/release-22/README.md).

Approach

Bump the root Cargo.toml pins for moq-noq-proto, moq-noq-udp, and web-transport-moq from 1.3.3 to 1.3.4, and Cargo.lock with cargo update --precise. Only those three plus moq-noq move in the lock, the same shape as #4702.

1.3.4 carries moq-dev/noq#29: the max datagram size is reported as 0 instead of panicking.

main already pins 2.0.1, so this is a release-only bump with nothing to land on main first.

Impact

  • Public API: none.
  • Wire: none.

Checks

just check passed except three moq-uring worker tests that panicked with io_uring memory counts against RLIMIT_MEMLOCK (8192 KiB). This was the local runner's per-user memlock limit, used up by concurrent agents. I re-ran the rest of the workspace with clippy as the rustc wrapper and --no-fail-fast: 5458 passed. just rs _lint passes.

Follow-ups

  • Once this merges, delete quest/m0/release-22/noq.md on main and remove its entry from quest/m0/release-22/README.md Required. The quest file only exists on main.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 8, 2026 16:30
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A raw QUIC peer without datagram support now gets a max datagram size of 0 instead of a panic (moq-dev/noq#29).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Outcome of /quest-start for quest/m0/release-22/noq.md: the pin bump is complete, the PR is a draft, and there are no open decisions. Local checks pass, apart from the moq-uring memlock-limit failures described in the body. Those come from the environment, so CI is the real signal for them.

After this merges, delete quest/m0/release-22/noq.md on main and remove it from the questline's Required list.

(Written by Claude Opus 5.5)

@kixelated
kixelated marked this pull request as ready for review October 9, 2026 05:29
@kixelated

Copy link
Copy Markdown
Collaborator Author

A release-only bump of moq-noq-proto, moq-noq-udp, and web-transport-moq from 1.3.3 to 1.3.4. It picks up moq-dev/noq#29, which reports max datagram size as 0 instead of panicking when a raw QUIC peer has no datagram support. The diff is exactly the three Cargo.toml pins plus four lockfile entries (including moq-noq), the same shape as #4702, and nothing else moves. A panic reachable by any peer without datagrams is worth fixing on the 0.17 line before the draft-22 interop.

No issues found. CI is green. The one follow-up is the one the PR already lists: delete quest/m0/release-22/noq.md on main after merge.

Verdict: MERGE. Reviewed head: 931b72cb.

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging via /quest-merge. The diff is the three Cargo.toml pins (moq-noq-proto, moq-noq-udp, web-transport-moq) plus the matching Cargo.lock entries, 1.3.3 to 1.3.4. CI is green and the earlier review found no issues. As a trivial pin bump it needs no further review. No open decisions.

Follow-up: delete quest/m0/release-22/noq.md on main and drop its entry from quest/m0/release-22/README.md Required.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit 256f6bb into release Oct 9, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/release-22/noq branch October 9, 2026 16:33
kixelated added a commit that referenced this pull request Oct 9, 2026
Resolve every conflict to main's side, which already carries each release change:

- Cargo.toml/Cargo.lock: keep main's moq-noq 2.0.2 stack over release's 1.3.4 pins (#5072).
- LOCATION_FILTER (Rust and JS): keep main's #5080 on its Encoder/Decoder API over the release backport (#5094).
- model/track.rs, cache.rs, group.rs, tests/rejoin.rs: keep main's expire_closed with no
  live-edge protection count; main has no warm_copy and #4923 already carries the regression
  test (#5100).
- quest/m0/release-22: keep main's retirement of the finished children.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant