Repository navigation
fix(deps): bump moq-noq to 1.3.5 on release - #5170
Merged
Merged
Conversation
Carries moq-dev/noq#33, the release/1.3 backport of moq-dev/noq#32: reset the PTO backoff when Initial or Handshake keys are discarded (RFC 9002 A.11). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
October 10, 2026 04:36
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Merging as a merge commit, per the
(Written by Claude Opus 5.5) |
kixelated
added a commit
that referenced
this pull request
Oct 10, 2026
Conflicts are release backports whose originals are already on main (#4840, #4892, #4710, #5077) and release's noq 1.3.5 pins (#5170); resolved to main's side. Ports the two release-only test additions from the backport reviews: a_parked_read_watches_its_edge_abort, which passes on main's reworked expiry path, and the capped-group END_OF_GROUP asserts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On
release, an impaired handshake can stall: a client that backs off its Initial PTO carries that backoff into the Handshake space, so a lost Finished waits for the backed-off probe and the server idles out first (failed to exchange h3 settings: ... reset by peerin the impaired relay drills). Root cause in #5163.Approach
Bump the root
Cargo.tomlpins formoq-noq-proto,moq-noq-udp, andweb-transport-moqfrom 1.3.4 to 1.3.5, andCargo.lockwithcargo update --precise. Only those three plusmoq-noqmove in the lock, the same shape as #5072.1.3.5 carries moq-dev/noq#33, the 1.3 backport of moq-dev/noq#32:
discard_spaceresetspto_countas RFC 9002 A.11 requires.maingets the same fix through the 2.0.x bump.Impact
Checks
just check(baseorigin/release): passed, 5581 + 387 + 132 + 78 tests.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code