Skip to content

fix(net): give the group-order session test its limits - #5048

Merged
kixelated merged 1 commit into
mainfrom
fix/session-test-limits
Oct 8, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/session-test-limits

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

main does not compile moq-net's lib tests. #4927 added a group-order test in rs/moq-net/src/ietf/session.rs that builds ietf::session::Config without the limits field #4820 added, and the two merged independently.

error[E0063]: missing field `limits` in initializer of `ietf::session::Config<_>`
    --> rs/moq-net/src/ietf/session.rs:1783:38

Fix

Pass limits: Default::default(), as every other test in the file does.

Impact

Test-only. No public API or wire change.

cargo nextest run -p moq-net passes (1612 tests).

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

#4927 added an ietf::session test that builds Config without the limits
field #4820 added, so moq-net's lib tests no longer compile on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 464c4664-13b0-457e-ab47-6b5d54309718
📥 Commits

Reviewing files that changed from the base of the PR and between 2717724 and edf7e04.

📒 Files selected for processing (1)
  • rs/moq-net/src/ietf/session.rs
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Automated review of edf7e04a

One-line test fix: the group-order test added in #4927 builds ietf::session::Config without the limits field from #4820, so moq-net's lib tests don't compile on main. Adding limits: Default::default() matches every other initializer in the file.

I checked rs/moq-net/src/ietf/session.rs on main: there are eight Config { .. } initializers in the test module, and this is the only one missing limits, so after this change all eight set it. The non-test constructors in client.rs and server.rs already pass limits, so nothing else is broken by the same merge race.

No issues found. CI is still queued; the Test job is the one that matters here, since it's what was failing to build.

Worth landing quickly: any open moq-net PR that merges main will hit the same E0063 in its Test job until this is in.

Verdict: MERGE once CI is green.

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: edf7e04a7a7bca3b39dc6dbda21cf604aa65c88a (full PR).

No actionable findings. Independently checked the base/head diff, Config::limits, its defaults, and the other session-test initializers; this agrees with the existing assessment. Adding limits: Default::default() at rs/moq-net/src/ietf/session.rs:1799 is the minimal fix for the missing-field initializer and leaves the invalid-GROUP_ORDER assertions intact. No broader refactor is needed for this test-only repair.

Verification: GitHub source inspection only; I did not run tests. The author's reported 1,612-test pass is not independently verified; the Check workflow's Check and Test jobs were still queued when checked.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging. One-line test fix: the group-order test from #4927 now passes limits: Default::default(), the field #4820 added to ietf::session::Config, so moq-net's lib tests compile on main again.

  • Verified cargo test -p moq-net --lib --no-run builds with this change applied on current main (2870c0c).
  • The OpenAI review of edf7e04a (the current head) found nothing actionable.
  • Test-only; no public API or wire change.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit d1ea6eb into main Oct 8, 2026
8 checks passed
@kixelated
kixelated deleted the fix/session-test-limits branch October 8, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant