Repository navigation
fix(net): give the group-order session test its limits - #5048
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Automated review of One-line test fix: the group-order test added in #4927 builds I checked No issues found. CI is still queued; the Worth landing quickly: any open Verdict: MERGE once CI is green. This is an automated review, not the maintainer's decision |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: edf7e04a7a7bca3b39dc6dbda21cf604aa65c88a (full PR).
No actionable findings. Independently checked the base/head diff, Config::limits, its defaults, and the other session-test initializers; this agrees with the existing assessment. Adding limits: Default::default() at rs/moq-net/src/ietf/session.rs:1799 is the minimal fix for the missing-field initializer and leaves the invalid-GROUP_ORDER assertions intact. No broader refactor is needed for this test-only repair.
Verification: GitHub source inspection only; I did not run tests. The author's reported 1,612-test pass is not independently verified; the Check workflow's Check and Test jobs were still queued when checked.
|
Merging. One-line test fix: the group-order test from #4927 now passes
(Written by Claude Opus 5.5) |
Problem
maindoes not compilemoq-net's lib tests. #4927 added a group-order test inrs/moq-net/src/ietf/session.rsthat buildsietf::session::Configwithout thelimitsfield #4820 added, and the two merged independently.Fix
Pass
limits: Default::default(), as every other test in the file does.Impact
Test-only. No public API or wire change.
cargo nextest run -p moq-netpasses (1612 tests).(Written by Claude Opus 5.5)
🤖 Generated with Claude Code