Skip to content

quest: move relay session limits back to m1, no release gate - #5047

Merged
kixelated merged 1 commit into
mainfrom
quest/relay-session-limits-m1
Oct 8, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/relay-session-limits-m1

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

While merging #4820, the merge agent took the maintainer's "merge" as option 1 of an open cluster-cap question (comment 6050708340). As a result, it moved quest/m1/relay-session-limits.md to m0 and marked it as gating the next release. The maintainer never made that call.

Approach

  • Move the quest back to quest/m1/relay-session-limits.md and restore its m1 README entry.
  • Drop the m0 README entry and the "Session caps ... gates the next release" paragraph.
  • Keep the factual flap risk in the quest's Plan: past 10,000 subscriptions, a cluster link closes and flaps on reconnect. Record that the quest does not gate a release.

✅ Revert to m1, no gate (chosen)

  • Keep the m0 release gate
  • Move to m0, no release gate

Impact

  • Public API: none. Wire: none. Quest files only; quest check passes.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

#4820's merge moved the quest to m0 as a release gate. The maintainer
decided against that: it stays in m1 and does not gate a release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b6de20b5-fffc-479c-9ade-cfe74b2b72a4
📥 Commits

Reviewing files that changed from the base of the PR and between 2717724 and 8ca39e5.

📒 Files selected for processing (3)
  • quest/m0/README.md
  • quest/m1/README.md
  • quest/m1/relay-session-limits.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Grok review of 8ca39e5 (quest/docs only)

Accurate revert of the m0 move that landed with #4820. I checked it against main:

  • No other quest or doc on main links /quest/m0/relay-session-limits.md. The only references were the m0 README's Session caps paragraph and Required entry, and this PR removes both, so no link breaks after the rename.
  • The facts kept in the quest's Plan match the code: moq_net::session::Limits::default() is 100,000 announces and 10,000 subscriptions (rs/moq-net/src/session.rs:665-670), and moq-relay doesn't set Limits anywhere yet (nothing in cluster.rs, session.rs or config.rs), so cluster links get the same default and can hit TooManyRequests.
  • The m0 Goal and Plan text that's left don't mention session caps, and the broadcast-epoch release gate paragraph is unchanged, so the README doesn't contradict itself.

Non-blocking:

  • With the gate gone, the next release ships feat(net)!: bound peer-declared lengths and per-session requests #4820's caps while peer links still use the 10,000-subscription default. A mesh link past that closes and flaps on reconnect. That's your call to make, but it may be worth a line in the moq-relay release notes so operators running large clusters know about it until this quest lands.

No blocking issues. CI (Check, Quest, Test) was still queued when I reviewed.

Verdict: MERGE once CI is green.

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed full commit 8ca39e5dabc6a274564800f022be1300bc6b846c against 2717724cec9e608681fb1a0ad6a1d7fce70d266c.

No actionable findings. The three-file change consistently moves the quest and its README entry back to m1, removes the m0 release gate, and retains the existing cluster-cap flap warning. This is a minimal implementation of the stated planning decision; public API, wire behavior, and runtime limits are unchanged.

Verification: inspected the complete diff, changed documents, quest tree, and linked #4820 discussion through GitHub. No local commands or tests run; Check, Test, and Quest are queued. Rechecked that the PR is open and non-draft, the head is unchanged, and there are no existing reviews or inline findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary for 8ca39e5d:

Enabling auto-merge pinned to 8ca39e5dabc6a274564800f022be1300bc6b846c.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) October 8, 2026 06:09
@kixelated
kixelated merged commit 2f39fde into main Oct 8, 2026
5 checks passed
@kixelated
kixelated deleted the quest/relay-session-limits-m1 branch October 8, 2026 06:25
kixelated added a commit that referenced this pull request Oct 8, 2026
Takes main's quest tree (#5058 squashed, #5046, #5047, #5060, and the rest)
and reapplies only this PR's delta. gpu-surface was deleted on main after
#4975 finished it, so its Kind::Auto decision drops.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant