Repository navigation
quest: sync with moq.pro's quest audit, add Kotlin POM and Homebrew moq-gst fixes - #5059
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deletes done and not-worth-it quests, folds duplicates, retires m4 into m3, moves quests between milestones by priority, splits js-session-parity and listener-deadlines, and fixes every rank inversion the audit found. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…xt-32-57d5a2 # Conflicts: # quest/m0/README.md # quest/m0/ietf-d14-root-prefix.md # quest/m1/README.md # quest/m1/js-request-window.md # quest/m1/js-session-parity.md # quest/m1/lite07-finalize.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oq-gst fixes Repoint or drop stale moq.pro links, record decisions moq.pro made (input-device Config field, combined health verdict lives in moq.pro), name moq.pro consumers, and add two m1 quests: the Kotlin wrapper's target POMs depend on an unpublished moq-ffi 0.0.0-dev, and the moq-gst Homebrew formula installs from the wrong tarball path. If stats-split splits, the per-path map retirement moves with prefix tracks and self counters, since moq.pro's Broadcasts page reads prefix tracks the moment the maps retire. Applies on top of #5058 (2026-10-08 audit), which already dropped the rtsp-import #2210 note and deleted text-schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: f70f08e (stacked base: 2e42af0).
No actionable defects found in this quest-only delta. The direction is sound: keep map retirement with its prefix-track replacement, make device selection explicit before encoder open/probe, and give the two packaging failures focused regression checks.
Non-blocking simplification: in quest/m1/gst-brew-path.md:13–19, correcting the source glob alone can retain the current lib destination, caveat, and test contract. Move the destination and drop the caveat only if the proposed Homebrew discovery check demonstrates the benefit.
Verification: read the full 12-file diff, surrounding quests, Kotlin publishing configuration/workflow, Homebrew template and packaging workflow, encoder open/probe, and stats contract. Static GitHub review only; no tests or quest check run. Maven Central artifacts and downstream moq.pro links were not independently checked (repository-only scope). Check CI is still running. Rechecked open/non-draft state, head/base and empty review history immediately before posting; GitHub currently reports merge conflicts.
Automated review: moq#5059 at
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 seconds. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merged
(Written by Claude Opus 5.5) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follows #5058 (the 2026-10-08 audit), now merged; this PR targets
main.Problem
moq.pro's 2026-10-07 quest audit found upstream quests that link to moved or deleted moq.pro quests, leave open questions moq.pro has since decided, or omit moq.pro as a consumer. It also turned up two broken published artifacts that no quest owns: the Kotlin wrapper's target POMs on Maven Central depend on
moq-ffi-jvm/moq-ffi-android0.0.0-dev, which was never published, and the Homebrewmoq-gstformula globslib/libgstmoq.*while the tarball shipslib/gstreamer-1.0/, so it installs nothing.#5058 also lets stats-split ship prefix tracks and self counters in a follow-up while retiring the per-path maps first. moq.pro's Broadcasts page reads prefix tracks the moment the maps retire, so a release that retires them alone is one moq.pro cannot pin, which also holds back every later pin.
Approach
m2/lite07.md(held in m2 until the cut), and stats-split no longer claims moq.pro'sannouncedprobe reads totals.Kind::Autodecision dropped in the main merge: feat(video)!: accept external Vulkan encoder inputs #4975 finished that quest and main deleted it.tls://links), dogfood-assets (moq.pro's package adoption), gpu-release (moq.pro's release and pin quests).quest/m1/kt-ffi-pom.md) and Homebrew moq-gst (quest/m1/gst-brew-path.md), ranked beside Wire compatibility.#5058 already dropped the rtsp-import #2210 note and deleted text-schema, so this PR no longer touches either. Some moq.pro links resolve once the moq.pro audit PR merges (
quest/m2/gpu-release.md,quest/m1/edge-core/qmux-credit.md,quest/m2/lite07.md).Impact
Quest files only. Public API: none. Wire: none.
quest checkpasses.Alternatives
moqffi.version. Kept as the second option in kt-ffi-pom; the recommendation is the range, matching Gradle consumers.Decisions
Upstream PR
New quests' milestone
stats-split split
Follow-ups
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code