Skip to content

quest: drop the stats-epoch link #4904 deleted - #5044

Merged
kixelated merged 1 commit into
mainfrom
fix/js-session-parity-link
Oct 8, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/js-session-parity-link

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

#4904 deleted quest/m0/broadcast-epoch/stats-epoch.md, but quest/m1/js-session-parity.md still links to it. quest check, and with it the Quest CI job, now fails on main and on every PR that merges main.

Approach

Impact

  • Public API: none. Wire: none.

Alternatives

None. The link target no longer exists.

Follow-ups

The same quest Requires quest/m0/request-caps.md, which #4820 deletes, so #4820 needs to update it when it lands.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 53809638-92fa-40ed-8717-822346d9fe6c
📥 Commits

Reviewing files that changed from the base of the PR and between 8a55152 and dfdca5d.

📒 Files selected for processing (1)
  • quest/m1/js-session-parity.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Grok review of dfdca5db

This fixes the dead link, and the new wording matches the code on main. I checked each claim:

Non-blocking

  1. The bindings half of the check doesn't have anything to compare yet. moq-ffi exposes no broadcast or route epoch today. The only epoch there is MoqSession::epoch (rs/moq-ffi/src/session.rs:854-860), which is the connection reconnect count. Someone picking this up could compare the wrong value. Consider wording it as "add a moq-ffi accessor for Info::epoch and check it matches", and say outright that MoqSession::epoch is unrelated.
  2. The follow-up in the description is correct: feat(net)!: bound peer-declared lengths and per-session requests #4820 deletes quest/m0/request-caps.md, which this quest still lists under Required, so feat(net)!: bound peer-declared lengths and per-session requests #4820 will break quest check the same way unless it updates this file.

CI (Check, Test) is still queued at this head. Nothing in the diff should fail it.

Verdict: MERGE once CI is green.

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: dfdca5d.

No actionable bugs found in the full one-file diff. Removing the dead Related link is the simplest fix: its target is absent, while both remaining linked quests exist at this head. The revised epoch wording matches Rust broadcast::Info::epoch and JS broadcast.Consumer.epoch; #4904 and #4967 are merged. No public API or wire changes.

The future #4820 dependency cleanup is already noted in the description and Grok's review; no duplicate finding added.

Verification: GitHub-only source and repository-tree inspection. I did not run quest check or tests; the Check workflow was queued when inspected.

(Written by OpenAI)

@kixelated
kixelated merged commit ebc9438 into main Oct 8, 2026
4 checks passed
@kixelated
kixelated deleted the fix/js-session-parity-link branch October 8, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant