fix(net): pass the epoch to request_broadcast in dial_split_horizon

[kixelated]

Problem

main at 6425fe5d2 doesn't compile moq-net's tests. #5025 added rs/moq-net/tests/dial_split_horizon.rs, which calls request_broadcast("room"), while #4904 gave request_broadcast a required epoch argument. Both landed close together. Every PR that touches moq-net now fails Test in the merge queue.

Approach

Pass None, as every other caller does.

Impact

• None. Test-only.

Alternatives

None.

Follow-ups

• quest: drop the stats-epoch link #4904 deleted #5044 fixes the other break on main: a quest link to stats-epoch.md that feat(stats)!: publish each group announcement under its own epoch #4904 deleted.

cargo check --workspace --all-targets --locked and just rs test -p moq-net pass.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: a2987c47-9aca-4970-973c-cb2ea9faf5e9

📥 Commits

Reviewing files that changed from the base of the PR and between ebc9438 and 4be28e1.

📒 Files selected for processing (1)

• rs/moq-net/tests/dial_split_horizon.rs

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kixelated]

Automated review of 4be28e1d

Correct, minimal fix. main (ebc94386) still has the one-argument .request_broadcast("room") at rs/moq-net/tests/dial_split_horizon.rs:178, while OriginConsumer::request_broadcast in rs/moq-net/src/model/origin.rs:4332 now takes epoch: impl Into<Option<crate::Epoch>>. Passing None matches the other Rust callers, and it was the only one-argument Rust caller I could find (the request_broadcast(path) calls in py/moq-rs go through the Python binding's own API, so they aren't affected).

No issues found. CI (Check, Test, and the platform builds) was still queued at the time of review. Since the point of this PR is to get Test green again, it's worth confirming that before merging.

The companion break on main (the stats-epoch.md quest link) is handled separately in #5044. Both need to land before the merge queue is unblocked.

Verdict: MERGE (once CI is green)

This is an automated review, not the maintainer's decision
(Written by Grok)

[kixelated]

Automated review by review (OpenAI)

Reviewed commit: 4be28e1

No actionable defect found in the full one-line change. At rs/moq-net/tests/dial_split_horizon.rs:178, passing None matches the required epoch argument and preserves unpinned lookup (rs/moq-net/src/model/origin.rs:4322–4338), so the split-horizon assertions keep their intended meaning. This independently agrees with the existing review; no duplicate inline finding.

Direction is sound and limited to fixing the test's compile break. Verification: GitHub-only static review of the complete patch, test context, and API contract; no local build/tests run. Current-head workflows remain queued, so compilation and test success are not yet independently verified. Open state, exact head, and reviews rechecked before submission.

[kixelated]

Merging. One-line, test-only fix: dial_split_horizon.rs now passes None as the epoch argument to request_broadcast, matching every other caller, so moq-net's tests compile on main again. CI is green on 4be28e1, and the OpenAI review of that head found no issues. No decisions were open. #5044, the other main break, has already merged.

(Written by Claude Opus 5.5)