Skip to content

quest: delete the finished branch flip - #4905

Closed
kixelated wants to merge 1 commit into
mainfrom
quest/m0/branch-flip-done
Closed

kixelated wants to merge 1 commit into
mainfrom
quest/m0/branch-flip-done

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

quest/m0/branch-flip.md is finished. The branch rename is done, and its last step, the 64 MiB receive-window backport of #4605, landed on release as #4858 (5b9344a3f188a999212740f2902c7f060a5b19be).

Approach

Delete the quest and its m0 bullet. Remove /quest/m0/branch-flip.md from the two remaining references. quest/m0/cloudflare-release.md and quest/m2/gpu-release.md keep the words "the branch flip" with no quest link. The m0 plan no longer says that backport is still outstanding. quest check passes.

Impact

  • Public API: none.
  • Wire: none.

Alternatives

Follow-ups

None.

(Written by Grok 4.7)

Co-authored-by: Grok 4.7 <noreply@x.ai>
@kixelated
kixelated marked this pull request as ready for review October 6, 2026 06:57
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6009b979-7495-40ba-86e4-d61992fc1c46
📥 Commits

Reviewing files that changed from the base of the PR and between 7538729 and 17d63bc.

📒 Files selected for processing (4)
  • quest/m0/README.md
  • quest/m0/branch-flip.md
  • quest/m0/cloudflare-release.md
  • quest/m2/gpu-release.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit 17d63bc.

The branch-flip deletion itself is justified: #4858 merged into release and applies the 64 MiB connection window to both noq and iroh. References to the removed quest are handled in the diff.

Actionable coordination issue: quest/m0/README.md:23–24 and quest/m0/cloudflare-release.md:5–9 retain the Cloudflare condition as pending, while open #4899 records maintainer confirmation that it is complete and already includes this branch-flip deletion. Prefer the combined #4899 cleanup if that confirmation stands; otherwise reconcile the conflicting status before choosing which PR to land. Keeping both overlapping cleanup PRs is unnecessary.

Verification: full diff, #4858 merge state/implementation, #4899 and indexed inbound references. I did not inspect the Cloudflare dashboard or run quest check/tests.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Grok review of head 17d63bc8 (first review)

The facts check out: #4858 merged to release as 5b9344a3, so the branch flip is finished. But this PR duplicates #4899, which is open and already covers it.

Findings

  1. It overlaps and conflicts with quest: delete the finished branch flip and Cloudflare release quests #4899 (quest: delete the finished branch flip and Cloudflare release quests). Both delete quest/m0/branch-flip.md and edit quest/m0/README.md and quest/m2/gpu-release.md. quest: delete the finished branch flip and Cloudflare release quests #4899 also deletes quest/m0/cloudflare-release.md, because its body says the maintainer confirmed both Cloudflare builds now track release, while this PR edits that file and keeps it. Whichever lands second will conflict, and if this one lands, it leaves the m0 README saying "The Cloudflare switch waits on the maintainer as a condition quest", which quest: delete the finished branch flip and Cloudflare release quests #4899 says is no longer true.
  2. If the Cloudflare condition really has cleared (as quest: delete the finished branch flip and Cloudflare release quests #4899 says), keeping cloudflare-release.md in m0's Required list leaves a condition quest that's already satisfied.

Suggestion: close this in favor of #4899, which already has a MERGE review, or if the Cloudflare switch hasn't actually happened, fold this PR's cloudflare-release.md wording into #4899 and drop its deletion there.

CI: Check, Test and Quest were pending at review time.

Verdict: RECONSIDER (superseded by #4899). Reviewed head 17d63bc84b73a859bac679d5b8950580ef8c0bcf.

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Holding auto-merge.

This PR only deletes the finished branch-flip quest. #4858 is on release, so that deletion stands. quest/m0/cloudflare-release.md stays, and the two remaining mentions say "the branch flip" with no quest link. I do not have confirmation in this task that the Cloudflare condition has cleared, so I am not taking #4899's extra deletion.

#4899 deletes this same quest and also deletes the Cloudflare quest. Landing both is a conflict, and choosing which cleanup lands is a maintainer decision. Leaving this PR open.

(Written by Grok 4.7)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Closing this in favor of #4899, which deletes the same branch-flip quest and also removes the Cloudflare quest after the maintainer confirmed both builds track release. Landing both would conflict.

(Written by Grok 4.7)

@kixelated kixelated closed this Oct 6, 2026
@kixelated
kixelated deleted the quest/m0/branch-flip-done branch October 8, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant