Skip to content

quest: delete the finished branch flip and Cloudflare release quests - #4899

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/branch-flip-delete
Oct 6, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/branch-flip-delete

Conversation

@kixelated

@kixelated kixelated commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes two finished m0 quests:

Both are removed from the m0 Required list. quest check passes.

Public API: none. Wire: none.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Its last step, backporting #4605's 64 MiB default receive window to
release, landed as #4858.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: efa36b28-3101-4d24-8bfe-c4fb16b26f03
📥 Commits

Reviewing files that changed from the base of the PR and between 3138f10 and d863d3b.

📒 Files selected for processing (4)
  • quest/m0/README.md
  • quest/m0/branch-flip.md
  • quest/m0/cloudflare-release.md
  • quest/m2/gpu-release.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Automated review of 37d122e (quest: delete the finished branch flip)

The deletion is justified. The quest's only remaining step was backporting #4605's 64 MiB default receive window to release, and #4858 (fix(moq-tokio): finite default connection receive window (backport #4605)) merged into release at 2026-10-06 06:27 UTC with the default applied in noq.rs and iroh.rs plus the relay config docs. A scan of every file under quest/ plus AGENTS.md and CONTRIBUTING.md on main finds links to branch-flip.md only in the three files this PR edits, so no link breaks.

No blocking issues.

Non-blocking

  1. Stale sentence in quest/m0/README.md (line 23, Plan section). It still says "The branch flip is done except its fix(moq-tokio): finite default connection receive window (noq reassembly cap, part 1) #4605 backport to release; the Cloudflare switch waits on the maintainer as a condition quest." After this PR the backport is done and the quest is gone, so the first half is wrong. Suggest: "The Cloudflare switch waits on the maintainer as a condition quest."
  2. The patch-only release policy loses its only written source. "Releases stay patch-only for now, so no cut follows the flip" (decided 2026-10-02) was recorded only in branch-flip.md. After the deletion, its only trace is the bare clause "releases are patch-only for now" in quest/m2/gpu-release.md. CONTRIBUTING.md covers how a cut works (lines 88–90) but not that cuts are on hold. If the policy is meant to outlive the quest, add one line to the release section of CONTRIBUTING.md (or a dated "decided 2026-10-02" in gpu-release.md) so the next agent planning a cut sees it.

CI (Check, Quest, Test) is still queued at review time.

Verdict: MERGE once CI is green. Item 1 is a one-line fix worth folding in.

This is an automated review, not the maintainer's decision
(Written by Grok)

Both Cloudflare builds (moq-doc and demo) now track release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title quest: delete the finished branch flip quest: delete the finished branch flip and Cloudflare release quests Oct 6, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Automated follow-up review of 1688403 (re-review after push; last review was on 37d122e, #issuecomment-6010823553)

The push adds 1688403 (quest: delete the cleared Cloudflare release condition), which deletes quest/m0/cloudflare-release.md and its entry in the m0 Required list. The removal is mechanically clean: the only files linking to cloudflare-release.md on main are quest/m0/README.md and quest/m0/branch-flip.md, both handled here, so no link breaks. The condition itself (both Cloudflare projects' production branch reads release) lives in the Cloudflare dashboard, so it can't be checked from the repo; the deletion rests on the maintainer's confirmation stated in the PR body.

Earlier findings

  1. Still open, and now fully stale: quest/m0/README.md lines 23–24 (Plan). It still reads "The branch flip is done except its fix(moq-tokio): finite default connection receive window (noq reassembly cap, part 1) #4605 backport to release; the Cloudflare switch waits on the maintainer as a condition quest." After this push both halves are false: the backport landed (fix(moq-tokio): finite default connection receive window (backport #4605) #4858) and the Cloudflare condition quest is deleted. The m0 README now describes two pieces of work that no longer exist. Fix: delete both lines (nothing is left to say about the flip in m0).
  2. Still open (non-blocking): the patch-only release policy has no written source. Unchanged from the last review. With both quests gone, "releases stay patch-only for now" survives only as a bare clause in quest/m2/gpu-release.md. A line in the release section of CONTRIBUTING.md, or a dated "decided 2026-10-02" in gpu-release.md, would keep it findable.

New (non-blocking)

  1. The PR title on GitHub now covers both quests, but the first commit's subject (quest: delete the finished branch flip) is what a squash merge may default to. Worth making sure the squash subject names both deletions.

CI (Check, Test, Quest) is still pending on 1688403.

Verdict: ITERATE. Only finding 1 needs a change, and it's a two-line deletion; MERGE once that lands and CI is green.

This is an automated review, not the maintainer's decision
(Written by Grok)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Automated follow-up review of d863d3b (re-review after push; last review was on 1688403, #issuecomment-6010874511)

The push adds d863d3b (quest: drop the stale branch flip note from m0), which deletes the two stale Plan lines from quest/m0/README.md and changes the gpu-release.md link to the deleted quest into "(decided 2026-10-02)".

Earlier findings

  1. Fixed. The stale "branch flip is done except its fix(moq-tokio): finite default connection receive window (noq reassembly cap, part 1) #4605 backport…" sentence is gone, and the m0 README at this head no longer mentions the flip, Cloudflare, or fix(moq-tokio): finite default connection receive window (noq reassembly cap, part 1) #4605. The surrounding Plan paragraph still reads cleanly.
  2. Fixed. quest/m2/gpu-release.md now dates the patch-only policy ("decided 2026-10-02") instead of linking to the deleted quest. That also removes what would have been a broken link.
  3. Still open (non-blocking). The first commit's subject only names the branch flip, so make sure the squash subject names both deletions (the PR title already does).

A code search of main finds branch-flip.md and cloudflare-release.md referenced only in files this PR edits or deletes, so no links break.

CI (Check, Test, Quest) is still pending on d863d3b.

Verdict: MERGE once CI is green.

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit d863d3b.

No actionable code/documentation defects found. Removing the completed quests is sound: #4858 is merged into release, and its diff applies the 64 MiB default in both noq and iroh. The current diff removes the indexed inbound links and stale m0 status, and preserves the dated patch-only decision in quest/m2/gpu-release.md:14–16, addressing the existing review findings.

Coordination: #4905 independently deletes the same branch-flip quest; prefer this combined cleanup if the reported Cloudflare confirmation stands, rather than landing both overlapping changes.

Verification: full diff, #4858 merge state/implementation, existing discussions and repository link search. Cloudflare dashboard/live-doc parity is not independently verified; that completion rests on the maintainer confirmation recorded in this PR. No commands or tests run.

@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

(Written by Grok 4.7)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T07:31:46.043624Z d863d3b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: d863d3b936

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kixelated
kixelated enabled auto-merge (squash) October 6, 2026 09:20
@kixelated

Copy link
Copy Markdown
Collaborator Author

Deleting both finished m0 quests.

No public API or wire change. The squash subject is the PR title, which names both deletions. Check, Test, and Quest are green on d863d3b9364a97139884adc6d9a1129beddaa0b9.

(Written by Grok 4.7)

@kixelated
kixelated merged commit eec0637 into main Oct 6, 2026
5 of 11 checks passed
@kixelated
kixelated deleted the quest/m0/branch-flip-delete branch October 6, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant