Skip to content

quest: delete stats-linger now that its release backport merged - #4888

Merged
kixelated merged 1 commit into
mainfrom
quest/stats-linger-done
Oct 6, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/stats-linger-done

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

quest/m0/stats-linger.md tracked the release backport of #4871, which merged as #4882.

Approach

Delete the quest and every link to its path (quest/m0/README.md, stats-aggregate-bound.md, stats-split.md); bench-buckets.md now points at #4882 as its backport example.

Impact

  • None (quest docs only). quest check passes.

Alternatives

None.

Follow-ups

None.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

The release backport (#4882) of #4871 merged, so the quest is done.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Automated review: MERGE (once CI is green)

Reviewed head f0cc6069f9a433c9228069acbb5f6e23ad80fa92.

The deletion is justified: the release backport #4882 merged at 9de8d85, and that was the quest's only remaining work ("Delete this quest once the backport merges"). Every in-repo link to quest/m0/stats-linger.md is removed, and the bench-buckets.md retarget to #4882 is accurate (#4882 is the additive release cherry-pick of #4871). The remaining stats-linger hits on main are the relay's --stats-linger flag in rs/moq-relay, not links. CI (Check, Quest, Test) was still queued when I looked.

Non-blocking

  1. Conflicts with fix(moq-stats): bound the stats aggregate with a grace-window fold #4874. fix(moq-stats): bound the stats aggregate with a grace-window fold #4874 (head 4f8b939) edits quest/m0/stats-linger.md and deletes quest/m0/broadcast-epoch/stats-aggregate-bound.md, while this PR does the reverse: it deletes stats-linger.md and edits stats-aggregate-bound.md. That's a modify/delete conflict both ways, plus an adjacent-line conflict in the Related list of stats-split.md (this PR drops the Stats linger line, fix(moq-stats): bound the stats aggregate with a grace-window fold #4874 drops the Bounded stats aggregate line right after it). Whichever lands second gets the fix: delete both files and drop both Related lines.
  2. Cross-repo dangling links. moq.pro's quest/m0/stats-linger.md on main links twice to https://github.com/moq-dev/moq/blob/main/quest/m0/stats-linger.md (in the Plan, and under Required as "A moq-dev/moq release commit carries upstream's stats linger"). Both will 404 once this merges. Since feat(stats): linger an empty group broadcast before unannouncing it (backport #4871) #4882 has now merged, a moq.pro follow-up could point those links at feat(stats): linger an empty group broadcast before unannouncing it (backport #4871) #4882 / commit 9de8d85 and check off the Required item.

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: f0cc606

No new actionable defects found in the five-file diff. Direction is sound: #4882 is merged into release at 9de8d85, satisfying the deleted quest's explicit completion condition; quest/m1/bench-buckets.md:42–45 now preserves a durable backport example. The remaining stats-split plan retains the linger behavior and #4871 reference. No runtime, public API, or wire changes.

Independently confirmed the cross-repository dangling links already reported in the existing review: moq.pro's quest/m0/stats-linger.md:31–32,42–43 still links to the deleted path. Retarget those references to #4882 in the adoption follow-up; no duplicate inline finding added.

Verification limits: static diff/document review and live backport-state verification only; I did not run quest check or tests. The head's Check workflow was queued when inspected.

(Written by OpenAI)

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b3f2b287-87bc-43a7-ad46-c2acb27c0796
📥 Commits

Reviewing files that changed from the base of the PR and between 1b5faed and f0cc606.

📒 Files selected for processing (5)
  • quest/m0/README.md
  • quest/m0/broadcast-epoch/stats-aggregate-bound.md
  • quest/m0/broadcast-epoch/stats-split.md
  • quest/m0/stats-linger.md
  • quest/m1/bench-buckets.md
💤 Files with no reviewable changes (4)
  • quest/m0/stats-linger.md
  • quest/m0/broadcast-epoch/stats-aggregate-bound.md
  • quest/m0/broadcast-epoch/stats-split.md
  • quest/m0/README.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.


Walkthrough

The change deletes the Stats linger quest document and removes its listing and links from related quest documentation. It also changes the backport example to PR #4882.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to f0cc6

This documentation-only change accurately reflects the completed backport and leaves no broken links to the deleted quest, so no actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to f0cc6

The change affects 1 system.

Changed systems: quest

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — quest (service) was modified; 5 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in quest/m0/README.md: Removed the paragraph stating that Stats linger joined m0 as a standalone quest, was not a release gate, and needed to land on main and be backported for moq.pro’s m0.
  • observed — Modified behavior in quest/m0/README.md: Removed the Required-list entry for Stats linger, including the note that the release backport remained and that it addressed grouped stats broadcasts re-announcing on viewer churn.
  • observed — Modified behavior in quest/m0/broadcast-epoch/stats-aggregate-bound.md: Removed the Related-section link to the Stats linger document.
  • observed — Modified behavior in quest/m0/broadcast-epoch/stats-split.md: Removed the Related-list link to the Stats linger document.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the completed stats-linger quest is being deleted after its release backport merged.
Description check ✅ Passed The description explains why the quest is deleted, lists the documentation changes, and reports the check result.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated merged commit 51d0108 into main Oct 6, 2026
5 checks passed
@kixelated
kixelated deleted the quest/stats-linger-done branch October 6, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant