Skip to content

quest: settle the moq-mux Clock boundary #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 2 commits into from
Oct 2, 2026
Merged

quest: settle the moq-mux Clock boundary #4700

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3873e5d
quest: settle the moq-mux Clock boundary
kixelated Oct 2, 2026
1ab08a5
Merge remote-tracking branch 'origin/quest/m1/test-flakes-2/README' i…
kixelated Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions quest/m1/test-flakes-2/mux-live-import-clock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,9 @@ re-exported from `moq-mux`, and the json and binary timed writes
`std::time::Instant` from `test_util::late_clock`, moq-cli publish, moq-hls
export, moq-audio and moq-video capture, and the catalog producer tests.

Open (maintainer, ask before starting): keep the public inputs on
`std::time::Instant` and convert at the boundary (native only; additive, stays
on `main`), or switch them to `web_async::time::Instant` as a typed break on
`dev` and update every caller and doc. Recommended: convert at the boundary,
so only the private epoch moves.

Public API: none if converted at the boundary; otherwise `Clock::at` and the
timed writes change type. Wire: none.
Decided (maintainer, 2026-10-01): convert at the boundary. Public inputs stay
`std::time::Instant` and convert to the private epoch internally (native only),
so this is additive and stays on `main`. Rejected: switching the public types to
`web_async::time::Instant` as a break on `dev`.

Public API: none. Wire: none.
Loading