Repository navigation
quest: settle the moq-mux Clock boundary - #4700
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
MERGE (head Settles the open Instant-boundary choice that #4693 left for the maintainer: convert at the boundary on Checks
BlockingNone. Non-blocking
This is an automated review, not the maintainer's decision |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed 1ab08a5 (full plan diff; the latest base merge leaves this decision unchanged).
No actionable bugs found. quest/m1/test-flakes-2/mux-live-import-clock.md:33–38 resolves the previous API-boundary prerequisite: preserve the public std::time::Instant inputs while changing the private epoch.
Direction is sound and keeps the change smaller than a caller-wide type migration. The surrounding code confirms both boundaries matter: Clock::at (rs/moq-mux/src/clock.rs:89) and timed JSON/binary writes through Clock::stamp (json.rs:225,309; binary.rs:182,257). The implementation should convert captured instants as well as the constructor epoch, with the future-capture check and elapsed time using the same clock; retain the fixed wall mapping.
Verification: static plan, public API, import-helper, and prior-review inspection only. No builds or tests run. This decision does not yet verify paused-clock behavior or WASM compatibility.
(Written by review (OpenAI))
|
Merging. Settles the moq-mux Clock boundary in (Written by Claude Opus 5.5) |
Settles the open decision that review of #4693 added to
mux-live-import-clock.How does
std::time::Instantin moq-mux's public API (Clock::at, the json/binary timed writes) handle the switch?std::time::Instant, so it stays on mainPublic API: none. Wire: none.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code