Skip to content

quest: link the two outside conditions main rejects - #4666

Merged
kixelated merged 1 commit into
mainfrom
fix/quest-outside-conditions
Oct 1, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/quest-outside-conditions

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

quest check (bumped in #4626) refuses plain-text Required bullets, and two quests landed on main afterwards with one each, so the required Check fails on every PR (seen on #4132).

Public API / wire impact: none.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

admission-bench and cluster-shims landed with plain-text Required bullets,
which the bumped quest check refuses, so Check fails on every PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head 1e6e96a766cfcd0af476e08ba4516767eb0d8a47 and all four changed files. No concrete bugs found.

Direction: this fixes the invalid Required entries at the source, using the pinned quest validator's existing model. The wildcard link preserves the benchmark's dependency, and the indexed release-condition quest keeps shim removal blocked until the refusal ships. No API or wire impact.

Verification: inspected the linked quests, pinned validator/guide, #4601's merge, and the 0.15.8 GitHub release. Did not run quest check or independently verify crates.io; CI Check and Test are still running.

(Written by review, an OpenAI model)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Review (head 1e6e96a766cfcd0af476e08ba4516767eb0d8a47)

Fixes the two plain-text Required bullets that break quest check after #4626. Wildcard link and the new outside-condition quest shape match the convention; Check/Test are green.

Plan cites the wrong moq-relay release

quest/m1/relay-mesh-refusal-release.md Plan says newest is 0.15.8 (2026-09-28). crates.io already has 0.16.0 (published 2026-09-30 ~16:54Z). #4601 merged later that day (~18:27Z), and the moq-relay-v0.16.0 tree still has the old gossip --cluster-mesh path, so the outside condition is still unmet — but the recorded status is wrong. Sibling web-transport-moq-release.md names the live crates.io version; this should too, e.g. 0.16.0 (2026-09-30), cut before #4601 merged.

Nit: m1 README adjacency

#4626 lists each condition quest right before the quest it blocks (gpu-runner→gpu-ci, web-transport-moq-release→wt-close-upstream). The new entry sits with the other release conditions instead of immediately above cluster-shims. Move it up so /quest-spawn keeps them paired.

ITERATE — fix the Plan version (and optionally the README order), then this unblocks Check for everyone.

Reviewed head: 1e6e96a766cfcd0af476e08ba4516767eb0d8a47

This is an automated review, not the maintainer's decision
(Written by Grok)

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e2175973-233a-47eb-bf49-bc27cc699581

📥 Commits

Reviewing files that changed from the base of the PR and between eb3e971 and 1e6e96a.

📒 Files selected for processing (4)
  • quest/m1/README.md
  • quest/m1/admission-bench.md
  • quest/m1/cluster-shims.md
  • quest/m1/relay-mesh-refusal-release.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The changes add a quest to track a moq-relay release that refuses --cluster-mesh, including the recorded release status and the cleanup condition. The milestone index and cluster-shims quest link to this quest. The admission-bench quest now links to the Wildcard README as the location of the admission walk.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 1e6e9

The release quest accurately leaves the refusal outstanding, and both required links meet the quest-check contract. No actionable merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 1e6e9

The change affects 1 system.

Changed systems: quest

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — quest (service) was modified; 4 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in quest/m1/README.md: Added a required quest for a moq-relay release that refuses --cluster-mesh.
  • observed — Modified behavior in quest/m1/admission-bench.md: Replaces the note that the wildcard line lands on main and cites quest(wildcard): Wildcard advertisements #4403 with a link to the Wildcard README, describing it as the line where the admission walk lives.
  • observed — Modified behavior in quest/m1/cluster-shims.md: Replaces the plain-text requirement for a moq-relay release carrying the --cluster-mesh refusal with a link to the release that carries the last refusal.
  • observed — Modified behavior in quest/m1/relay-mesh-refusal-release.md: Adds a quest describing the release condition, the cleanup required when it holds, and the latest release status as of 2026-10-01.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title describes the main change: linking the two required conditions that the quest check rejects. The wording is slightly informal but remains clear and related to the changeset.
Description check ✅ Passed The description directly explains both quest updates, the quest-check failure, and the absence of public API or wire impact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated merged commit 8d71f82 into main Oct 1, 2026
3 checks passed
@kixelated
kixelated deleted the fix/quest-outside-conditions branch October 1, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant