chore(quest): delete the announce live marker, follow-only moq announced - #4511
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
MERGEPositive improvement? Yes. This turns a patch-the-marker quest tree into a delete-the-marker plan, which matches how the marker is actually used. Only one-shot Worth the complexity? The PR itself is cheap (quest docs only). The planned work is large, but the split is sane: rename/follow-only CLI first so nothing in moq-cli still reads Different approach? A session-scoped Ship the quest direction. Implementation should stay ruthless about deleting marker-only machinery rather than stubbing it, and update every This is an automated review, not the maintainer's decision |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 797235afd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…xample Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 756e57bf47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…t paths Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merging on the maintainer's go-ahead. Changes since the first review, all quest text:
All three Codex threads are fixed and resolved; Codex gave a thumbs up on (Written by Claude Opus 5.5) |
Replaces the live-marker work with a deletion. Changes to the quest tree:
quest/m1/cli-announced.md[M]:moq lsbecomes a follow-onlymoq announcedwith a live view. Remote path completion is dropped.quest/m1/announce-live-removal.md[L]: deletes the announceLivemarker and its hold/replay machinery from Rust, JS, ffi, and bindings. Requires the CLI quest first.announce-live-apps.md,announce-page-load.md,announce-empty-state.md, andjs-active-count.md, whose only purpose was the marker.Supersedes #4369.
The marker only exists on
dev(#4059, #4261, #4266), so deleting it breaks nothing published. Wire: none. Lite's Active Count and the IETF Active Count extension stay on the wire, unused.Decisions (maintainer, 2026-09-29)
What does
livefix? It answers "has the initial list arrived?" Onlymoq ls(one-shot) and shell completion read it. Room, watch, and the demo skip it.Where should "caught up" live?
Given only one-shot listing needs it, what happens to
live?Quiet-period guess on lite-03/04 and IETF?
Single-connection listing (
session.live(prefix) -> Vec)?moq ls --followbecomes the only mode, renamedmoq announced, with a live UI. One-shot listing waits for a customer.Empty-state UI (announce-empty-state.md)?
Shell completion of remote broadcast paths?
Live UI for
moq announced?The old
moq lsname?Split?
dev:moq lsonly exists there)Wire Active Count?
js-active-count.md (JS speaks the IETF Active Count extension)?
#4369?
Superseded earlier the same day: the Live/Offline toggle, hold-and-reconcile, and the JS queue rewrite now.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code