Skip to content

chore(quest): moq-cli shell completion stays local-only - #4515

Merged
kixelated merged 1 commit into
devfrom
claude/cli-announced-local-completion
Sep 29, 2026
Merged

kixelated merged 1 commit into
devfrom
claude/cli-announced-local-completion

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

#4511 added quest/m1/cli-announced.md, and its merge kept the catalog-rendition completers (--video-name, --audio-name), which dial a relay and read a catalog during shell completion. The maintainer decided against any network completion.

Approach

  • quest/m1/cli-announced.md: the Goal says completion is local-only (flags, subcommands, local capture devices). The Plan records the decision (2026-09-29, no network completion) and why: completion stays fast and works offline. The rendition completers, and any plumbing that only lets a completer dial, go with the BROADCAST completer.
  • quest/m1/README.md: the entry's summary matches.

No other quest on dev references these completers.

Decisions

Drop all network completion?

  • Keep renditions
  • ✅ Drop all network

Impact

  • Quest-only. Public API and wire: none. (The planned work removes --video-name/--audio-name completion from moq-cli.)

Alternatives

  • Keep the rendition completers: rejected, since they dial a relay on every tab press.

Follow-ups

None.

🤖 Generated with Claude Code
(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T16:50:15.390022Z 9e27a4e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Recommendation: MERGE

Quest-only clarification that moq-cli shell completion stays local-only (flags, subcommands, local capture devices)—no dialing a relay or reading a catalog during tab-complete. README summary and cli-announced.md Goal/Plan stay in sync; the Plan records the 2026-09-29 decision and drops BROADCAST plus the --video-name/--audio-name rendition completers (and dial-only plumbing) with that work.

(a) Positive improvement? Yes. Network completion on every tab press is the wrong UX (latency, offline failure, surprises). Documenting “drop all network” before the implementation work lands keeps the quest honest and avoids shipping half a story from #4511.

(b) Worth the complexity? Yes—trivial. Two quest files, +11/−8, no public API or wire change. Complexity is in the later code change this quest now correctly specifies, not in this PR.

(c) Different approach better? No. Keeping rendition completers was considered and rejected for the same reason as BROADCAST. Narrowing only BROADCAST while leaving catalog dials would leave the same class of bug. Quest-doc-first is the right scope here.

Not a release-plz bump. Safe to merge as written.

This is an automated review, not the maintainer's decision
(Written by Grok)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Summary: the moq announced quest now plans local-only shell completion; the catalog-rendition completers are dropped along with the BROADCAST completer. The decision is the maintainer's (2026-09-29) and the change is quest-only, so no further review is needed. Enabling auto-merge.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge September 29, 2026 16:49
@kixelated
kixelated merged commit 8e25668 into dev Sep 29, 2026
3 checks passed
@kixelated
kixelated deleted the claude/cli-announced-local-completion branch September 29, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant