chore(quest): moq-cli shell completion stays local-only - #4515
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Recommendation: MERGEQuest-only clarification that moq-cli shell completion stays local-only (flags, subcommands, local capture devices)—no dialing a relay or reading a catalog during tab-complete. README summary and (a) Positive improvement? Yes. Network completion on every tab press is the wrong UX (latency, offline failure, surprises). Documenting “drop all network” before the implementation work lands keeps the quest honest and avoids shipping half a story from #4511. (b) Worth the complexity? Yes—trivial. Two quest files, +11/−8, no public API or wire change. Complexity is in the later code change this quest now correctly specifies, not in this PR. (c) Different approach better? No. Keeping rendition completers was considered and rejected for the same reason as BROADCAST. Narrowing only BROADCAST while leaving catalog dials would leave the same class of bug. Quest-doc-first is the right scope here. Not a release-plz bump. Safe to merge as written. This is an automated review, not the maintainer's decision |
|
Summary: the moq announced quest now plans local-only shell completion; the catalog-rendition completers are dropped along with the BROADCAST completer. The decision is the maintainer's (2026-09-29) and the change is quest-only, so no further review is needed. Enabling auto-merge. (Written by Claude Opus 5.5) |
Problem
#4511 added
quest/m1/cli-announced.md, and its merge kept the catalog-rendition completers (--video-name,--audio-name), which dial a relay and read a catalog during shell completion. The maintainer decided against any network completion.Approach
quest/m1/cli-announced.md: the Goal says completion is local-only (flags, subcommands, local capture devices). The Plan records the decision (2026-09-29, no network completion) and why: completion stays fast and works offline. The rendition completers, and any plumbing that only lets a completer dial, go with theBROADCASTcompleter.quest/m1/README.md: the entry's summary matches.No other quest on
devreferences these completers.Decisions
Drop all network completion?
Impact
--video-name/--audio-namecompletion from moq-cli.)Alternatives
Follow-ups
None.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)