Skip to content

quest: libmoq CMake finds the library cargo built #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 2 commits into from
Sep 26, 2026
Merged

quest: libmoq CMake finds the library cargo built #4289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c55d2
quest: libmoq CMake finds the library cargo built
kixelated Sep 26, 2026
d96c411
quest(libmoq-cmake-lib): regression test in CI
kixelated Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/shared
Open in desktop
Submodule shared updated 2 files
+6 −0 close/SKILL.md
+6 −0 merge/SKILL.md
1 change: 1 addition & 0 deletions quest/m1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ transport, benchmark tooling); worktrees isolate commits, not semantics.
- [Kotlin JVM exit](/quest/m1/kt-jvm-exit.md) - a Kotlin/JVM program exits cleanly whatever the moq-ffi runtime thread is doing, like Python does since #3766
- [Dart publish](/quest/m1/dart-publish.md) - the packages are built and dry-run clean but exist nowhere consumers can install from
- [Dart codec parity](/quest/m1/dart-codecs.md) - Dart is the one binding that cannot originate media
- [libmoq CMake library](/quest/m1/libmoq-cmake-lib.md) - the in-tree CMake build links the `libmoq.a` cargo reports, not a hardcoded `target/<profile>` path
- [libmoq fetch](/quest/m1/libmoq-fetch.md) - libmoq gains an additive cached-group fetch entry point
- [moq-mux on wasm32](/quest/m1/mux-wasm-target.md) - the crate's two wasm blockers are fixed and the target stays in the clippy lane
- [#2850](/quest/m1/2850-js-net-give-reader-a-synchronous-decode-so-the-publisher.md) - js/net: decode messages synchronously from buffered bytes and delete the publisher read-ahead queue
Expand Down
27 changes: 27 additions & 0 deletions quest/m1/libmoq-cmake-lib.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# [XS] libmoq CMake finds the library cargo built

## Goal

`rs/libmoq/CMakeLists.txt` links the static library cargo actually produced,
whatever `CARGO_TARGET_DIR`, `--target` triple, or profile the build uses.
Today `BUILD_RUST_LIB` assumes `target/<debug|release>/libmoq.a`, so any other
layout links a stale library or fails to find one.

## Plan

- `cmake/cargo-build.cmake` already parses cargo's JSON messages to find
`moq.h` in its hashed `OUT_DIR`. Read the libmoq `compiler-artifact`
message's staticlib filename from the same output and copy it beside the
header in the CMake binary dir, `ONLY_IF_DIFFERENT`. `RUST_LIB` then points
there. Chosen over forcing `--target-dir` into the build dir, which loses
the shared workspace cache, and over `cargo metadata`, which still guesses
the triple and profile subdirectories.
- The `BUILD_RUST_LIB=OFF` prebuilt path is unchanged.
- Regression test in CI: the existing `cpp/obs` build against `MOQ_LOCAL`
runs with `CARGO_TARGET_DIR` outside `target/`, so a hardcoded path fails
the build. Update `rs/libmoq/README.md` and `doc/lib/c` if they describe
the path.

## Related

- [libmoq shutdown](/quest/m1/libmoq-shutdown.md) - the other libmoq packaging fix OBS needs
Loading