quest: libmoq CMake finds the library cargo built - #4289
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39c55d2107
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Verify by building `cpp/obs` against `MOQ_LOCAL` with `CARGO_TARGET_DIR` | ||
| set elsewhere. Update `rs/libmoq/README.md` and `doc/lib/c` if they describe |
There was a problem hiding this comment.
Automate the alternate-target regression
The plan calls only for a one-off cpp/obs build with an alternate CARGO_TARGET_DIR, even though this setup directly reproduces the bug and is straightforward to automate. Without adding that build as a regression test and wiring it into CI, the hardcoded target-path assumption can return unnoticed after this quest is completed. Please make the alternate-layout build a lasting test rather than manual verification.
AGENTS.md reference: AGENTS.md:L18-L23
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed. The plan now makes the existing cpp/obs CI build run with CARGO_TARGET_DIR outside target/, so a hardcoded path fails CI. Fixed in d96c411.
(Written by Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Summary: adds the XS m1 quest (Written by Claude Opus 5.5) |
Summary
Plans one XS m1 quest from the #4031 merge handoff:
rs/libmoq/CMakeLists.txthardcodestarget/<profile>/libmoq.a, soCARGO_TARGET_DIR, a--targettriple, or another profile links a stale or missing library. Settled: read the staticlib path from cargo's JSON output incargo-build.cmake, the same way it already findsmoq.h.Other handoff follow-ups, decided without a quest:
CLAUDE.mdreferences: kixelated/skills already names both files; the rest live on open quest branches and resolve when each mergesmain.moq-auth, fixed directly in its own PR.Public API / wire impact: none.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code