Skip to content

quest: libmoq CMake finds the library cargo built - #4289

Merged
kixelated merged 2 commits into
mainfrom
quest/followups-4031
Sep 26, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/followups-4031

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Plans one XS m1 quest from the #4031 merge handoff: rs/libmoq/CMakeLists.txt hardcodes target/<profile>/libmoq.a, so CARGO_TARGET_DIR, a --target triple, or another profile links a stale or missing library. Settled: read the staticlib path from cargo's JSON output in cargo-build.cmake, the same way it already finds moq.h.

Other handoff follow-ups, decided without a quest:

  • Leftover CLAUDE.md references: kixelated/skills already names both files; the rest live on open quest branches and resolve when each merges main.
  • The paused-clock loopback audit (after test(relay): run the outage lease test on the real clock #4244) found one remaining race, in moq-auth, fixed directly in its own PR.

Public API / wire impact: none.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review September 26, 2026 20:31
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 48ac7eba-b98a-4a2b-80dc-939838a2ee85

📥 Commits

Reviewing files that changed from the base of the PR and between ed7e697 and d96c411.

📒 Files selected for processing (3)
  • .claude/shared
  • quest/m1/README.md
  • quest/m1/libmoq-cmake-lib.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T20:33:16.168340Z 39c55d2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39c55d2107

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/libmoq-cmake-lib.md Outdated
Comment on lines +20 to +21
- Verify by building `cpp/obs` against `MOQ_LOCAL` with `CARGO_TARGET_DIR`
set elsewhere. Update `rs/libmoq/README.md` and `doc/lib/c` if they describe

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Automate the alternate-target regression

The plan calls only for a one-off cpp/obs build with an alternate CARGO_TARGET_DIR, even though this setup directly reproduces the bug and is straightforward to automate. Without adding that build as a regression test and wiring it into CI, the hardcoded target-path assumption can return unnoticed after this quest is completed. Please make the alternate-layout build a lasting test rather than manual verification.

AGENTS.md reference: AGENTS.md:L18-L23

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The plan now makes the existing cpp/obs CI build run with CARGO_TARGET_DIR outside target/, so a hardcoded path fails CI. Fixed in d96c411.

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Summary: adds the XS m1 quest libmoq-cmake-lib (CMake reads the staticlib path from cargo's JSON; regression covered by running the cpp/obs CI build with a non-default CARGO_TARGET_DIR). Codex P2 addressed. Quest-only change; just check passes.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) September 26, 2026 20:36
@kixelated
kixelated merged commit 6493a3e into main Sep 26, 2026
3 checks passed
@kixelated
kixelated deleted the quest/followups-4031 branch September 26, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant