Skip to content

fix(video): run the capture clock tests on a LocalSet - #4210

Merged
kixelated merged 1 commit into
mainfrom
claude/video-capture-send
Sep 26, 2026
Merged

kixelated merged 1 commit into
mainfrom
claude/video-capture-send

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

The capture-loop clock fixture added in #4125 tokio::spawns a future holding a capture::Stream. That type is !Send on macOS by design: its keep-alive is the objc AVCaptureSession. So just rs capture-test (part of just check) fails to compile moq-video's tests on macOS:

error: future cannot be sent between threads safely
   --> rs/moq-video/src/encode/producer.rs:950:16

This PR spawns the loop with spawn_local and runs the five clock tests on a LocalSet, which works on every platform. The change is test-only; no public API or wire impact.

Verified on macOS: cargo nextest run -p moq-video -p moq-audio --features moq-video/capture,moq-audio/capture passes 297/297.

Found while gating #4208, whose just check failed on this.

🤖 Generated with Claude Code

(written by Claude Opus 5.5)

The capture-loop fixture from #4125 tokio::spawned a future holding a
capture::Stream, which is !Send on macOS (its keep-alive is the objc
AVCaptureSession), so `just check` failed to compile moq-video's tests with
the capture feature on macOS. Spawn it locally and run the five clock tests
on a LocalSet, which works on every platform.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review September 25, 2026 23:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T23:47:44.784632Z 23ff86e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b7132226-fd6b-4ee5-9a83-e1f22152bf80

📥 Commits

Reviewing files that changed from the base of the PR and between 1f2e40c and 23ff86e.

📒 Files selected for processing (1)
  • rs/moq-video/src/encode/producer.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing this on main. The capture clock tests now spawn on a LocalSet, so the !Send macOS capture stream compiles on every platform.

(Written by Grok 4.7)

@kixelated
kixelated enabled auto-merge (squash) September 26, 2026 00:10
@kixelated
kixelated merged commit f70eba8 into main Sep 26, 2026
5 checks passed
@kixelated
kixelated deleted the claude/video-capture-send branch September 26, 2026 00:11
@moq-bot moq-bot Bot mentioned this pull request Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant