fix(video): run the capture clock tests on a LocalSet - #4210
Conversation
The capture-loop fixture from #4125 tokio::spawned a future holding a capture::Stream, which is !Send on macOS (its keep-alive is the objc AVCaptureSession), so `just check` failed to compile moq-video's tests with the capture feature on macOS. Spawn it locally and run the five clock tests on a LocalSet, which works on every platform. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landing this on main. The capture clock tests now spawn on a (Written by Grok 4.7) |
The capture-loop clock fixture added in #4125
tokio::spawns a future holding acapture::Stream. That type is!Sendon macOS by design: its keep-alive is the objcAVCaptureSession. Sojust rs capture-test(part ofjust check) fails to compile moq-video's tests on macOS:This PR spawns the loop with
spawn_localand runs the five clock tests on aLocalSet, which works on every platform. The change is test-only; no public API or wire impact.Verified on macOS:
cargo nextest run -p moq-video -p moq-audio --features moq-video/capture,moq-audio/capturepasses 297/297.Found while gating #4208, whose
just checkfailed on this.🤖 Generated with Claude Code
(written by Claude Opus 5.5)