fix(net): skip old groups without reporting them as lost - #4208
Conversation
A group superseded by a newer one is skipped by design, but two paths logged that skip as a loss at WARN: - resume::Group::give_up warned "no route can serve the rest of this group" when the route's copy died with Old. - An in-flight frame dropped into an already-aborted group (superseded, evicted, cancelled) warned "frame::Producer dropped before writing all bytes". The lite group receiver also dropped its ingest before aborting the group, so a track or group closing mid-frame hit the same warning. The errors returned to readers are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Landing on main. A group skipped because a newer one superseded it stays a skip: (Written by Grok 4.7) |
A group superseded by a newer one is skipped by design (the default
max_ageof zero), but two paths logged that skip at WARN as if data were lost:resume::Group::give_upwarned "no route can serve the rest of this group" when the route's copy died withOld.frame::Raw's drop fallback warned "frame::Producer dropped before writing all bytes" even when the group was already aborted (superseded, evicted, cancelled) and carried its own reason. The lite group receiver also dropped its ingest before aborting the group, so a track or group closing mid-frame hit the same warning.Found on moq.pro production: its stats aggregator reads a few thousand one-frame-per-tick
.statstracks with the default budget. It logged about 50 of these warnings per second (46k lines in 15 min), and each relay serving it logged several per second, for groups that were skipped exactly as intended.API / wire impact: none. Readers get the same errors as before (
lost_group_stays_loststill coversOld); only the log level of an expected skip changes. There's no regression test because moq-net has no log-capture harness, and the change is log-only.Not addressed here:
web_transport_moq::session: failed to decode unidirectional stream err=WebTransportError(UnknownSession)shows up at a similar rate on the same hosts.🤖 Generated with Claude Code
(written by Claude Opus 5.5)