Skip to content

quest(transport-upgrade): WebSocket upgrade edge cases #4204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 1 commit into from
Sep 26, 2026
+25 −0
Merged

quest(transport-upgrade): WebSocket upgrade edge cases #4204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m1/transport-upgrade/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Shared decisions:

## Quests

- [Rust edge cases](/quest/m1/transport-upgrade/polish.md) - no false GOAWAY warning on upgrade, and a failed WebSocket handshake falls back to the pending QUIC dial
- [JavaScript](/quest/m1/transport-upgrade/js.md) - js/net keeps the WebTransport dial after WebSocket wins and migrates through the client-goaway handover

## Related
Expand Down
24 changes: 24 additions & 0 deletions quest/m1/transport-upgrade/polish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# [S] WebSocket upgrade edge cases

## Goal

The Rust WebSocket-to-QUIC upgrade leaves no false warnings and no avoidable
failures: a GOAWAY the peer received is not logged as a send failure, and a
WebSocket handshake that fails after WebSocket won the dial race falls back to
the still-pending QUIC dial instead of failing the connection attempt.

## Plan

- Every upgrade logs `failed to send goaway: transport: connection closed`
although the server receives it. Find why the send reports failure (likely
the close racing the flush) and fix it at the source.
- When WebSocket wins the race but its MoQ handshake fails, the pending QUIC
dial is still alive; use it rather than failing, bounded by the existing
connect timeout.
- Tests for both, including the deterministic QUIC-held forwarder from #4189.

Public API: none. Wire: none.

## Related

- [#4189](https://github.com/moq-dev/moq/pull/4189) - the WebSocket-to-QUIC upgrade this polish quest follows
Loading