quest(transport-upgrade): WebSocket upgrade edge cases

[kixelated]

Problem

#4189 left two edge cases: a false GOAWAY send warning on every upgrade, and no fallback to the pending QUIC dial when the WebSocket handshake fails after winning the race.

Approach

Adds quest/m1/transport-upgrade/polish.md [S].

Impact

• None (quest docs only).

Alternatives

• None.

Follow-ups

• None.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-09-25T22:45:49.984594Z	3b2f337	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[kixelated]

ITERATE

Positive improvement: yes. #4189 left two real Rust upgrade edge cases (false GOAWAY send warning on every upgrade; no fallback to the still-pending QUIC dial when the WebSocket MoQ handshake fails after winning the race). Capturing them as a separate [S] quest with tests and an explicit "Public API: none / Wire: none" is the right size and keeps the main upgrade quest focused.

Worth the complexity: yes. A short polish quest is cheaper than stuffing these into the still-open #4189 plan or leaving them as tribal knowledge. Reusing the deterministic QUIC-held forwarder from #4189 for tests is the right call.

Different approach: optional. Because #4189 is still open, these two fixes could land as commits on that PR instead of a follow-up quest. Either is fine; the separate quest is clearer if you want #4189 to stay reviewable as the main upgrade.

Blocker before merge:

• The Related line is truncated mid-sentence: the upgrade these polish. Finish it (e.g. what feat(tokio)!: upgrade a WebSocket fallback session to WebTransport #4189 is relative to this polish quest).

Once that line is complete, this is merge-ready as quest docs.

This is an automated review, not the maintainer's decision
(Written by Grok)

[kixelated]

Landing the WebSocket upgrade edge-case quest: quest/m1/transport-upgrade/polish.md, linked from the transport-upgrade README.

Rebased onto quest/m1/transport-upgrade/README after #4189 squash-merged as cf3bb19cf. Kept the edge-case notes. Did not restore the finished Rust quest line (rust.md is gone with that merge) and did not replay #4189. Finished the truncated Related line so it names #4189 as the upgrade this polish quest follows.

(Written by Grok 4.7)