quest: libmoq becomes moq-c #4191
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # [M] libmoq becomes moq-c | ||
|
|
||
| ## Goal | ||
|
|
||
| The C bindings ship as `moq-c`, matching `moq-cpp` and the other bindings: the | ||
| crate, its directory, release tags, CMake package, and pkg-config file all use | ||
| the name. C code and link lines do not change: the header stays `moq.h` and the | ||
| library file keeps its current name. The published `libmoq` crate gets one last | ||
| release that points users at `moq-c`. | ||
|
|
||
| ## Plan | ||
|
|
||
| - Rename the crate `libmoq` to `moq-c` (`rs/libmoq` to `rs/moq-c`), its release | ||
| tags from `libmoq-v*` to `moq-c-v*`, and its workflow. The CMake package | ||
| becomes `find_package(moq-c)` and the pkg-config file `moq-c.pc`. The C++ | ||
| package is already `moq-cpp` (#4187), so the two install side by side. | ||
| - Keep the `[lib] name` so the library file and `moq.h` are unchanged. | ||
| - A published package rename is a break, so this lands on `dev`. Release | ||
| tooling (release-plz, alert and nightly workflows, cachix) must follow the | ||
| new name and tag; check every workflow that names libmoq. | ||
| - Update every consumer and reference: `cpp/obs` (`find_package`), interop | ||
| clients, `doc/lib/c`, `doc/bin/obs.md`, the root `CLAUDE.md` Cross-Package | ||
| Sync table, and quests that name libmoq. Grep the whole repository. | ||
| - Publish a final `libmoq` release whose README and description point at | ||
| `moq-c`, then stop publishing it. The maintainer cuts releases; the PR only | ||
| prepares it. | ||
|
Comment on lines
+24
to
+26
There was a problem hiding this comment.
After the planned manifest and directory rename, the workspace contains no package named Useful? React with 馃憤聽/ 馃憥. |
||
|
|
||
| Public API: the C ABI is unchanged; the crate, package, and tag names change. | ||
| Wire: none. | ||
|
|
||
| ## Related | ||
|
|
||
| - [C++ through moq-ffi](/quest/m1/cpp/README.md) - the `moq-cpp` package this name mirrors | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C++ package is not already
moq-cppin this tree:quest/m1/cpp/package.mdstill promisesfind_package(moq),moq.pc, andcpp-v*tags. Implementing both active plans as written therefore preserves the package-name collision that this quest is intended to eliminate. Update the C++ quest to themoq-cppcontract, or explicitly make this quest depend on a separate change that does so.Useful? React with 馃憤聽/ 馃憥.