quest: libmoq becomes moq-c - #4191
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
MERGEPositive improvement? Yes. The C bindings are the naming outlier ( Worth the complexity? Yes for a planning quest. This PR is docs-only and the plan is appropriately bounded: keep Different approach? Keeping the header and Ship the quest as written; the implementation PR can own the grep sweep and workflow renames. This is an automated review, not the maintainer's decision |
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 673b577be4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Rename the crate `libmoq` to `moq-c` (`rs/libmoq` to `rs/moq-c`), its release | ||
| tags from `libmoq-v*` to `moq-c-v*`, and its workflow. The CMake package | ||
| becomes `find_package(moq-c)` and the pkg-config file `moq-c.pc`. The C++ | ||
| package is already `moq-cpp` (#4187), so the two install side by side. |
There was a problem hiding this comment.
Align the C++ package plan with the claimed name
The C++ package is not already moq-cpp in this tree: quest/m1/cpp/package.md still promises find_package(moq), moq.pc, and cpp-v* tags. Implementing both active plans as written therefore preserves the package-name collision that this quest is intended to eliminate. Update the C++ quest to the moq-cpp contract, or explicitly make this quest depend on a separate change that does so.
Useful? React with 👍 / 👎.
| - Publish a final `libmoq` release whose README and description point at | ||
| `moq-c`, then stop publishing it. The maintainer cuts releases; the PR only | ||
| prepares it. |
There was a problem hiding this comment.
Keep libmoq publishable until its final release
After the planned manifest and directory rename, the workspace contains no package named libmoq, so the existing release-plz flow cannot publish the promised final crates.io release. In the stated one-PR implementation, the maintainer would have nothing publishable under the old name. Retain a deprecation-only libmoq package until that release is cut, or make the old-name release a prerequisite that lands before the rename.
Useful? React with 👍 / 👎.
|
Landing the Codex's two notes stay with the implementation. #4187 already names the C++ package (Written by Grok 4.7) |
Problem
The C bindings are the odd one out:
libmoq, installed as CMakemoqandmoq.pc, while C++ ships asmoq-cpp(#4187) and the other bindings follow amoq-<lang>pattern.Approach
Adds
quest/m1/moq-c.md[M], ranked right after the C++ line. It renames the crate, directory, tags, CMake package and pkg-config file tomoq-c, keepsmoq.hand the library file name, lands ondev, and prepares a finallibmoqrelease pointing atmoq-c.Impact
Alternatives
Follow-ups
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code