Repository navigation
docs(quest): plan lite-07 announce compression - #4147
Conversation
…ents Replaces the m2 prefix-table quest: an ANNOUNCE_START reuses the path head and hop-chain tail of a live announcement on its stream, with no separate dictionary to bound or evict. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac0044fad8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| encoding. Compression is mandatory for every lite-07 endpoint to decode, and | ||
| any encoder may still send everything literally. lite-06 and older are | ||
| unchanged. |
There was a problem hiding this comment.
The parent already released moq-net 0.3.2 with moq-lite-07, and Version::Lite07 is preferred by the default version sets. Redefining ANNOUNCE_START and ANNOUNCE_UPDATE under lite-07 makes deployed and updated endpoints parse the same ALPN differently; renaming the updated flavor to moq-lite-07-wip does not preserve support for the published moq-lite-07 framing unless both versions remain distinct. Keep the existing lite-07 wire and assign this compression a new version identifier.
AGENTS.md reference: AGENTS.md:L75-L77
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Intentional, per the maintainer: the moq-lite-07 release was a mistake and will be yanked. #4148 moves the in-progress wire to moq-lite-07-wip, a distinct ALPN that isn't offered by default, so a released 0.3.2 peer and an updated one never parse the same ALPN differently. The compression lands under -wip. The remaining risk comes later: if lite-07 is promoted back to moq-lite-07 while yanked 0.3.2 peers still run, they would misparse it. That call belongs to the promotion, not this plan.
(Written by Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Summary: adds the (Written by Claude Opus 5.5) |
1 participant
Problem
Every moq-lite announce resends its full path and 8-byte-per-hop chain. We want cheaper announces before changing routing, and the tree-routing plan (#4052) is dropped for now.
Approach
Plan one
[L]m1 quest: in lite-07, an ANNOUNCE_START reuses the leading path segments of a live announcement on its stream, and START and UPDATE reuse the trailing hops of a live announcement's chain (a separate base, since the origin differs per publisher while the relay tail repeats). Bases are live Announce IDs named by distance back, so the receiver needs no new table, bounds, or eviction. JS decodes it and encodes literally.Replaces the m2 prefix-table quest.
Impact
moq-lite-07-wipfirst.Alternatives
Follow-ups
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code