Repository navigation
quest(qos): Broadcast health and congestion #4133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f284037
quest: open the qos line
kixelated 84a6af5
Merge origin/main into quest/m1/qos/README
kixelated 59dfd64
Merge origin/main into quest/m1/qos/README
kixelated 88a5269
feat(stats): per-broadcast viewer lag and dropped media on egress row…
kixelated b10837f
Merge origin/main into quest/m1/qos/README
kixelated 94a566f
chore(quest): claim final-lag-sample
kixelated cff4c75
fix(net): sample a closing subscription's lag once more
kixelated 5b98e2b
fix(net): read a dead track's last bytes in the final lag sample
kixelated 13facea
fix(net): decide a stats entry is retired before reading it out
kixelated be233e6
Merge pull request #4451 from moq-dev/quest/m1/qos/final-lag-sample
kixelated 4c68bad
Merge origin/main into quest/m1/qos/README
kixelated a1e80a2
Merge origin/main into quest/m1/qos/README
kixelated 1b195ac
Merge origin/main into quest/m1/qos/README
kixelated 9c5189b
fix(net): keep spliced lag honest when a route is replaced (#5009)
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: moq-dev/moq
Length of output: 3199
🏁 Script executed:
Repository: moq-dev/moq
Length of output: 6459
Keep
#4133blocked by the splice quest.Although
#4381is closed, its description says#4845supersedes it and that#4133remains held untillag-splice.mdis fixed. The reviewed diff removes both the QoS requirement and the landing hold, whilelag-splice.mdis absent at this revision.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents