chore(quest): retire js-publish-discontinuity, delivered by #3982

[kixelated]

Problem

quest/m1/js-publish-discontinuity.md asked for a js/hang container producer that publishes a marker group, wired into js/publish encoder restarts. #3982 already shipped that: Container.Legacy.Producer.cut(end?) closes the group and writes the one-empty-frame marker group. The video encoder calls it whenever its encode loop stops (demand gap or capture swap), and the audio encoder writes its own marker on a demand gap (#4041 hardened that). The quest's plan, which describes a missing discontinuity(), is stale, and it still blocked publisher-clock.

Approach

• Delete the quest and its quest/m1/README.md entry.
• Drop it from publisher-clock's Required. That quest now records the settled path and the audio restart cases still unmarked, since it already owns source and encoder restarts.

Impact

• No public API or wire change. Quest files only.

Alternatives

• Implement the leftover "data tracks skip a sequence" bullet to match Rust moq-mux. Not done: no JS publisher cuts a data track (captions write one cue per group), and a skipped sequence makes the JS consumer wait up to max age before moving past the hole.
• Keep the quest and narrow it to audio pipeline rebuild markers. Not done: that is encoder-restart timing, which publisher-clock already covers.

Follow-ups

• publisher-clock is now ready.
• feat(publish): mark a discontinuity when an encoder pauses for demand #3982's noted follow-up still stands: fold Rust moq-mux cut()/discontinuity() into one call on dev to match JS.

🤖 Generated with Claude Code

(written by Claude Opus 5.5)

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-24T21:53:55.494734Z	8f0cbf3	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6526577c-36ea-4ca6-9dee-80a8cba6e208

📥 Commits

Reviewing files that changed from the base of the PR and between 08c370e and 8f0cbf3.

📒 Files selected for processing (3)

• quest/m1/README.md
• quest/m1/js-publish-discontinuity.md
• quest/m1/publisher-clock.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6212c1ad-86f6-4100-8b0e-b6c5131e83eb

📥 Commits

Reviewing files that changed from the base of the PR and between 2e27b4b and 08c370e.

📒 Files selected for processing (3)

• quest/m1/README.md
• quest/m1/js-publish-discontinuity.md
• quest/m1/publisher-clock.md

💤 Files with no reviewable changes (2)

• quest/m1/js-publish-discontinuity.md
• quest/m1/README.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.

---

Walkthrough

The publisher-clock quest plan now specifies that the video encoder calls Container.Legacy.Producer.cut() when its encode loop stops. It specifies that the audio encoder writes a marker on a demand gap, but not on an audio pipeline rebuild or framer input-gap reset. The discontinuity quest document and its README entry were removed.

Merge Risk: ⚪ Minimal · up to 08c37

The quest update is ready to merge after normal checks; no actionable risk is established.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: retiring the js-publish-discontinuity quest because it was delivered by #3982.
Description check	✅ Passed	The description explains why the quest is stale, lists the files changed, and states the impact and follow-ups. It is directly related to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

✨ Simplify code

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f0cbf3e87

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Keep source-switch discontinuities in scope

When <moq-publish> switches between its normal camera, screen, or file sources, the same Video.Capture created in element.ts survives and only Capture.out.frames is replaced (video/capture.ts:45-63). producer.cut() is attached to the outer #encode cleanup (video/encoder.ts:237-244), whereas replacing out.frames only reruns the nested reader effect at lines 281-335, so this common source swap does not emit a marker. During the switch gap, the previous group can therefore remain the live edge, so deleting the dedicated quest while stating that capture swaps are covered leaves this case untracked; retain it explicitly in publisher-clock or keep the quest.

Useful? React with 👍 / 👎.