Repository navigation
smoke_test.sh: --public-ports allows the ports published off loopback on purpose - #165
Merged
Cvicnaire merged 1 commit intoOct 14, 2026
Conversation
… on purpose montilab publishes the Shiny port on SHINY_BIND=0.0.0.0 (#142), so the containment check failed on 0.0.0.0:8051 and every staging deploy ended red for an intended condition. --public-ports lists host ports allowed off 127.0.0.1; only the port is matched, so any other publish, and any other port, is still caught, and the pass line names what was allowed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
17 of 20 tasks
Cvicnaire
deleted the
164-smoke_testsh-containment-allow-the-ports-deliberately-published-off-loopback
branch
October 14, 2026 14:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164. Part of the release in #154.
Since #143 montilab publishes the Shiny port on
SHINY_BIND=0.0.0.0on purpose (accepted knowingly on 2026-10-14: like the other lab apps on that host it is internet-reachable, with Shiny's login as the gate).scripts/smoke_test.sh --containmenthad no way to say so, failed on0.0.0.0:8051and made every staging deploy end red for an intended condition.What changed.
--public-ports 8051,...lists the host ports allowed off 127.0.0.1. Only the port is matched, so 0.0.0.0, a routable address and the IPv6 wildcard are all allowed for a listed port and still caught for any other port; a listed port that is on loopback after all is fine; the pass line names what was allowed. Unlisted publishes behave exactly as before.Callers. The montilab deploy script (outside this repository, in sigrepo-ops) now derives the flag from
SHINY_BINDin.env: anything other than127.0.0.1passes--public-ports ${SHINY_PORT:-8051}.Tests. The ops harness (
tests/test_smoke_test.shin sigrepo-ops) gained seven cases: listed port on 0.0.0.0 and on[::]passes, the pass line names it, an unlisted port alongside is still caught, a listed port still on loopback passes, several ports, and a port that is only a suffix (51vs8051) is not matched. 25 of 25 pass against this script.🤖 Generated with Claude Code