Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the second, focused slice of the Action Ring work. It adds the core binding and a minimal text-only overlay while keeping the editor, icons, app catalog, folders, adjustments, and presets out of this PR.
PhysicalDevice*, preserving the per-device design from fix: route device actions to the right mouse; per-mouse profile tabs #174IDesktopIntegrationDesktop support
The overlay is enabled only when the active desktop integration reports Action Ring support. This PR implements and tests the KDE path. GNOME and Hyprland remain disabled until they have desktop-specific cursor-position sources.
Icons
This slice intentionally uses text labels only and contains no Action Ring SVG assets, so there is no new icon source or license to declare here. Icons will be handled separately in the editor/icons slice.
Validation
The reworked KDE/KWin/LayerShell path has unit and headless coverage. It has not yet been exercised in a live desktop session after this split.