Skip to content

Add Action Ring editor and licensed icons - #182

Draft
Dexarim wants to merge 2 commits into
mmaher88:masterfrom
Dexarim:feature/action-ring-editor-icons
Draft

Dexarim wants to merge 2 commits into
mmaher88:masterfrom
Dexarim:feature/action-ring-editor-icons

Conversation

@Dexarim

@Dexarim Dexarim commented Nov 9, 2026

Copy link
Copy Markdown

Dependency

Depends on #178.

This is a stacked draft because the core Action Ring branch currently exists only in the contributor fork. Until #178 is merged, GitHub will temporarily show the core commit in this PR as well. Once #178 lands in master, the diff will reduce to the editor/icons commit and this PR can be marked ready for review.

Summary

This is the third focused Action Ring slice. It adds only the editor and icons:

  • configure 2–8 Action Ring entries from the existing button action panel
  • preview the clockwise ring layout while editing
  • add, edit, remove, and reorder entries
  • edit existing actions, custom keyboard shortcuts, and launch commands
  • persist editor changes into the currently displayed per-device profile
  • restore editor state when switching devices or profiles
  • filter recursive Action Ring and gesture actions out of the ring action picker
  • keep invalid editor input from mutating the saved configuration

The app catalog, folders, adjustments, and ring presets remain out of scope.

Icons and license

The glyphs come from Lucide, pinned to commit 3fef7aca71a50acc54bd2f24f0cc4747c22aa6d2.

  • one SVG per glyph
  • tinted at runtime through Qt Quick Controls; no light/dark duplicate files
  • Lucide glyphs: ISC License
  • Feather-derived glyphs: MIT License
  • attribution and license text are included in src/app/qml/assets/actions/LICENSE.md

Validation

  • pre-push hook: passed
  • CTest: 841/841 passed
  • native test binary in one process: 831/831 passed
  • QML tests: 76/76 passed
  • QML lint: passed with existing project warnings
  • all SVG files pass XML validation
  • git diff --check: passed

No commit from the app catalog or later Action Ring slices is included.

@Dexarim

Dexarim commented Nov 9, 2026

Copy link
Copy Markdown
Author

Dependency clarification: after #178 is merged, I will explicitly rebase this branch onto the updated master and force-push the rebased branch before marking this PR ready for review. This is necessary because upstream commonly squash-merges PRs; the current cumulative 78-file diff is temporary and should not be reviewed as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant