Require B2B data consent on the contract dashboard by gumaerc · Pull Request #4006 · mitodl/mit-learn

gumaerc · 2026-09-28T21:38:05Z

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/13575

Description (What does it do?)

B2B learners now have to consent to share their learner data with their organization before they can use a contract's dashboard. Everything is behind the b2b-data-consent PostHog flag.

With the flag on, the contract dashboard shows a consent dialog whenever the learner's consent for that contract isn't true. The dialog can only be closed with Agree or Decline. Design: https://www.figma.com/design/mSDdN8giMcncBwNgwcVJL9/?node-id=21368-21707
Agree records consent and enables the cards. Decline records it as declined and closes the dialog, but it comes back on the next load or on a different contract.
Until consent is true, every card on the page is disabled: disabled CTA and context menu, and a plain-text title. Certificate links keep working.

Implementation details

Consent is read from consented_to_data_sharing on the contracts in mitxonline's users/me and written with POST /api/v0/b2b/data_consent/<contract_id>/. useDataConsentMutation stays pending until users/me refetches, so the dialog closes and the cards enable in the same render.
Dialog in ol-components gets a showCloseButton prop.
CoursewareCard and the enrolled/unenrolled cards get a disabled prop. ContractContent sets it on every card.
The mitxonline contract and organization test factories now return the learner types (UserContractPage/UserOrganizationPage), with consent defaulting to null.

Screenshots (if appropriate):

How can this be tested?

Requires mitxonline running mitodl/mitxonline#4039.

Enable b2b-data-consent in PostHog.
As a learner attached to a B2B contract that hasn't recorded consent, open the contract dashboard. The consent dialog appears, and Escape or clicking outside it does nothing.
Click Decline. The dialog closes, and every card shows a disabled CTA, a disabled menu and a plain-text title. Reload, and the dialog is back.
Check the box and click Agree and continue. The dialog closes and the cards are usable. Reload, and there is no dialog.
Open a different contract. The dialog appears again for it.
Turn the flag off. There is no dialog, and the cards behave as before.

Checklist:

Swap the @mitodl/mitxonline-api-axios branch build (GitHub tarball) for the released version once Return the user's data sharing consent on their B2B contracts mitxonline#4039 ships

github-actions · 2026-09-28T21:38:23Z

OpenAPI Changes

No changes detected

View full changelog

Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

Copilot

Copilot review overview

🟡 Changes recommended

The dashboard remains actionable while the consent feature flag is unresolved, creating a consent-bypass window.

Review effort: Balanced
Findings: 1

Open (1)

Block course access until the PostHog consent flag resolves · New

What changed in this PR

Adds feature-flagged B2B learner-data consent to contract dashboards.

Changes:

Adds a mandatory consent dialog and API mutation.
Disables course actions until consent is granted while preserving certificate links.
Updates MITx Online types, factories, dependencies, and tests.

File	Description
`yarn.lock`	Locks the updated MITx Online client.
`frontends/ol-components/src/components/Dialog/Dialog.tsx`	Supports hiding the close button.
`frontends/main/src/common/feature_flags.ts`	Registers the consent flag.
`frontends/main/src/app-pages/DashboardPage/DataConsentDialog.tsx`	Implements the consent dialog.
`frontends/main/src/app-pages/DashboardPage/DataConsentDialog.test.tsx`	Tests dialog behavior.
`frontends/main/src/app-pages/DashboardPage/DashboardLayout.test.tsx`	Updates organization types.
`frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/UnenrolledCourseCard.tsx`	Supports disabled unenrolled cards.
`frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/UnenrolledCourseCard.test.tsx`	Tests disabled unenrolled cards.
`frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/test-utils.ts`	Updates contract fixture types.
`frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/SiblingRunsAccordion.tsx`	Disables run actions.
`frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/OrganizationCards.test.tsx`	Updates organization fixture types.
`frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/EnrolledCourseCard.tsx`	Disables enrolled-card actions.
`frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/EnrolledCourseCard.test.tsx`	Tests disabled enrolled cards.
`frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/CoursewareCard.tsx`	Propagates disabled state.
`frontends/main/src/app-pages/DashboardPage/ContractContent.tsx`	Integrates consent state and mutation.
`frontends/main/src/app-pages/DashboardPage/ContractContent.test.tsx`	Tests consent dashboard flows.
`frontends/main/src/app-pages/DashboardPage/AnalyticsContent.test.tsx`	Updates organization types.
`frontends/main/package.json`	Updates the MITx Online client source.
`frontends/api/src/mitxonline/test-utils/urls.ts`	Adds the consent endpoint URL.
`frontends/api/src/mitxonline/test-utils/factories/organization.ts`	Uses learner organization types.
`frontends/api/src/mitxonline/test-utils/factories/contracts.ts`	Adds consent to contract fixtures.
`frontends/api/src/mitxonline/hooks/organizations/index.ts`	Adds the consent mutation hook.
`frontends/api/package.json`	Updates the MITx Online client source.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

gumaerc · 2026-09-29T18:29:20Z

@zamanafzal The API change has been released and the API package was upgraded, this is officially ready for a full review.

…onsent Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

…setup Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

…pi-generator v7.25.0 The previous branch build used v7.2.0, which names some types differently from published releases. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

zamanafzal

LGTM.
Tested locally against a B2B org with contract and flag on in PostHog.

Dialog shows on load of the contract dashboard while consent is unset
Ticked the checkbox and clicked Agree and continue — dialog closes and
does not come back on reload
On decline the dialog returns on the next load
Flag off in PostHog: no dialog regardless of consent state.
Until consent is true, both the enrolled and unenrolled cards stay gated —
CTA disabled.

* chore(api): use the mitxonline-api-axios branch build with contract consent Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(ol-components): let Dialog hide its close button Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(api): add useDataConsentMutation and learner contract factories Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(dashboard): add a disabled state to course cards Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(dashboard): add the B2B data consent dialog behind a feature flag Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(dashboard): require data consent on the B2B contract dashboard Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(dashboard): use learner contract and organization types in test setup Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(dashboard): show the consent spinner on the button that was clicked Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(api): rebuild the mitxonline-api-axios branch client with openapi-generator v7.25.0 The previous branch build used v7.2.0, which names some types differently from published releases. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * switch back to published api package --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

gumaerc requested a review from a team as a code owner September 28, 2026 21:38

Copilot AI balanced review requested due to automatic review settings September 28, 2026 21:38

Copilot started reviewing on behalf of gumaerc September 28, 2026 21:39 View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

Comment thread frontends/main/src/app-pages/DashboardPage/ContractContent.tsx

zamanafzal self-assigned this Sep 29, 2026

gumaerc force-pushed the cg/data-consent-modal branch 2 times, most recently from f8a28a0 to 4136cdb Compare September 29, 2026 18:14

gumaerc added the Needs Review An open Pull Request that is ready for review label Sep 29, 2026

gumaerc and others added 10 commits September 29, 2026 17:11

chore(api): use the mitxonline-api-axios branch build with contract c…

3097059

…onsent Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

feat(ol-components): let Dialog hide its close button

a3bd75e

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

feat(api): add useDataConsentMutation and learner contract factories

075d665

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

feat(dashboard): add a disabled state to course cards

f145a26

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

feat(dashboard): add the B2B data consent dialog behind a feature flag

d10a3ed

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

feat(dashboard): require data consent on the B2B contract dashboard

6ed11ac

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

test(dashboard): use learner contract and organization types in test …

5bbd7a7

…setup Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

fix(dashboard): show the consent spinner on the button that was clicked

a697061

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

chore(api): rebuild the mitxonline-api-axios branch client with opena…

fe24769

…pi-generator v7.25.0 The previous branch build used v7.2.0, which names some types differently from published releases. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

switch back to published api package

c50e26a

gumaerc force-pushed the cg/data-consent-modal branch from 74b7c08 to c50e26a Compare September 29, 2026 21:11

zamanafzal approved these changes Sep 30, 2026

View reviewed changes

gumaerc merged commit ae3adc7 into main Sep 30, 2026
14 checks passed

gumaerc deleted the cg/data-consent-modal branch September 30, 2026 15:18

odlbot mentioned this pull request Sep 30, 2026

Release 0.81.4 #4021

Merged

6 tasks done

gumaerc mentioned this pull request Sep 30, 2026

Data consent follow-ups: redirect on decline, fixed checkbox label color #4026

Open

Navigation Menu

Require B2B data consent on the contract dashboard - #4006

Require B2B data consent on the contract dashboard#4006
gumaerc merged 10 commits into
mainfrom
cg/data-consent-modal

gumaerc commented Sep 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

gumaerc commented Sep 29, 2026

Uh oh!

zamanafzal left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gumaerc commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What are the relevant tickets?

Description (What does it do?)

Screenshots (if appropriate):

How can this be tested?

Checklist:

Uh oh!

github-actions Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenAPI Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

gumaerc commented Sep 29, 2026

Uh oh!

zamanafzal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gumaerc commented Sep 28, 2026 •

edited

Loading

github-actions Bot commented Sep 28, 2026 •

edited

Loading