Conversation
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused changes match the stated behavior and include appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Updates B2B consent behavior and styling before production rollout.
Changes:
- Redirects declined learners to dashboard home while locking dialog actions.
- Keeps the consent checkbox label dark on hover.
- Updates redirect and disabled-state tests.
| File | Description |
|---|---|
DataConsentDialog.tsx |
Fixes checkbox label color. |
ContractContent.tsx |
Redirects after successful decline. |
ContractContent.test.tsx |
Tests redirect and locked actions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@steven-hatch Ferdi brought up an interesting point while I was testing this. He posited the question "why are we showing the popup once you've reached the contract page, rather than before?" He thought it made more sense if you're on dashboard home for example and you click one of the sidebar buttons or the org card button to show the popup right there before you even navigate to the page. What do you think? |
…ta consent Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…r decline Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
f4c9901 to
bcd4f03
Compare
|
I think that’s a reasonable alternative, and I’m good with either approach.
So I’d be comfortable with: show it before navigation when we can, and fall back to showing it on the contract page when that’s where the learner enters. @gumaerc we should still default to dashboard home on decline for both instances. Thank you. |
What are the relevant tickets?
Follow-up to #4006 for https://github.com/mitodl/hq/issues/13575
Description (What does it do?)
Changes to the B2B data consent dialog before the
b2b-data-consentflag is turned on in production.true, so hiding the dialog in the browser console still doesn't make them usable.How can this be tested?
b2b-data-consentin PostHog, with an up-to-date mitxonline (the consent field landed in Return the user's data sharing consent on their B2B contracts mitxonline#4039)./dashboard. Open the contract again, and the dialog is back.