feat: schema store support - #327628
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds SchemaStore catalog support to JSON language features.
Changes:
- Registers the public SchemaStore catalog.
- Loads remote registries through the schema request service.
- Refreshes associations when trust settings change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
extensions/json-language-features/package.json |
Registers the SchemaStore catalog. |
extensions/json-language-features/client/src/jsonClient.ts |
Supports trusted remote registry loading and refreshes. |
| getSchemaAssociations(true, true).then(associations => { | ||
| schemaAssociationRefreshIncludesRemoteRegistries = true; | ||
| client.sendNotification(SchemaAssociationNotification.type, associations); | ||
| }); |
| : await getRegistryContent(registryUri.toString(true)); | ||
| const registry = <{ schemas?: { url?: string; fileMatch?: string[] }[] }>JSON.parse(rawStr); | ||
| if (Array.isArray(registry.schemas)) { | ||
| const result: ISchemaAssociation[] = []; |
|
I find it difficult to understand what the PR exactly tries to achieve. Can we start with an issue that describes the requirements? I'm happy to take it from there and create PRs we don't need to discuss the details on how where what exactly be implemented (in the client, on the server, in the service...)
|
|
Martin Aeschlimann (@aeschli) sure, I've provided all the details I could think of here #26289 (comment) Let me know if you have any additional comments or questions. |
|
Closing this PR |
|
Martin Aeschlimann (@aeschli) are you starting a new pull request to implement that directly? Could you share the link please? |
Closes #325970
Supersedes #327297.
fixes #26289