Skip to content

feat: adds support for schema store - #342

Closed
Vincent Biret (baywet) wants to merge 4 commits into
microsoft:mainfrom
baywet:feat/schema-store
Closed

feat: adds support for schema store#342
Vincent Biret (baywet) wants to merge 4 commits into
microsoft:mainfrom
baywet:feat/schema-store

Conversation

@baywet

Copy link
Copy Markdown
Member

this pull request adds support for json schema store so schemas are suggested automatically based on https://www.schemastore.org/ when no $schema is present

…hema for the file

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c5e9b306-5d8c-4cc8-ac55-1b1175cfcedf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c5e9b306-5d8c-4cc8-ac55-1b1175cfcedf
@aeschli

Martin Aeschlimann (aeschli) commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Schema store loading and management should not be part of the JSON language service.

  • we don't want to hard-code any schema registry URL, nor it's file format
  • the requestService (type SchemaRequestService) is spec to load schemas, not catalogs. It's API and implemented by users of the service. VS Code is only one of them
  • there are already APIs to pass schema associations via the LanguageSettings. I would first try to get it working with these. If that doesn't work, add a (optional) property LanguageServiceParams.readFaillbackSchema: (resource: string) => string | undefined

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c5e9b306-5d8c-4cc8-ac55-1b1175cfcedf
@baywet

Copy link
Copy Markdown
Member Author

Martin Aeschlimann (@aeschli) thanks for the feedback. I've moved the code that resolves the catalog, etc... to the extension itself.
Let me know if you have any additional comments or questions.

@baywet

Copy link
Copy Markdown
Member Author

superseded by microsoft/vscode#327628

@baywet
Vincent Biret (baywet) deleted the feat/schema-store branch August 10, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants