feat: enables schema store support for the json language server - #325970
Open
Vincent Biret (baywet) wants to merge 3 commits into
Open
feat: enables schema store support for the json language server#325970Vincent Biret (baywet) wants to merge 3 commits into
Vincent Biret (baywet) wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds SchemaStore catalog support to JSON language features.
Changes:
- Adds an online-service setting for SchemaStore.
- Passes the setting to the JSON language service.
- Refreshes language status after schema diagnostics.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
jsonServer.ts |
Configures SchemaStore support. |
package.nls.json |
Adds the setting description. |
package.json |
Registers the SchemaStore setting. |
languageStatus.ts |
Exposes manual status refresh. |
jsonClient.ts |
Synchronizes settings and refreshes status. |
| validate: validateEnabled, | ||
| allowComments: true, | ||
| schemas: new Array<SchemaConfiguration>() | ||
| schemaStore: { enable: schemaStoreEnabled }, |
Member
Author
There was a problem hiding this comment.
that's expected for now, we'll need to merge/publish the related PR, and update the reference here.
Vincent Biret (baywet)
force-pushed
the
feat/schema-store
branch
from
July 21, 2026 11:54
72e9559 to
822dcfb
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5e9b306-5d8c-4cc8-ac55-1b1175cfcedf
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5e9b306-5d8c-4cc8-ac55-1b1175cfcedf
Contributor
|
Th PR touches many things that should not be necessary. Only change needed in getSchemaCatalogAssociations Note that in jsonClient we can use |
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on microsoft/vscode-json-languageservice#342