Skip to content

Fix customizations sidebar restoring previous section on reopen #311458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshspicer wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −3
Open

Fix customizations sidebar restoring previous section on reopen #311458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9dd6e1
Fix customizations sidebar restoring previous section on reopen
joshspicer Apr 20, 2026
f3ef89f
sessions: avoid runtime editor import in customization overview
Copilot Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/vs/sessions/contrib/aiCustomizationTreeView/browser/aiCustomizationOverviewView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { IPromptsService } from '../../../../workbench/contrib/chat/common/promp
import { PromptsType } from '../../../../workbench/contrib/chat/common/promptSyntax/promptTypes.js';
import { AICustomizationManagementSection } from '../../../../workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagement.js';
import { AICustomizationManagementEditorInput } from '../../../../workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditorInput.js';
import { AICustomizationManagementEditor } from '../../../../workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.js';
import { agentIcon, instructionsIcon, mcpServerIcon, pluginIcon, skillIcon } from '../../../../workbench/contrib/chat/browser/aiCustomization/aiCustomizationIcons.js';
import { IWorkspaceContextService } from '../../../../platform/workspace/common/workspace.js';
import { IAICustomizationWorkspaceService } from '../../../../workbench/contrib/chat/common/aiCustomizationWorkspaceService.js';
Expand Down Expand Up @@ -222,7 +223,13 @@ export class AICustomizationOverviewView extends ViewPane {

private async openOverview(): Promise<void> {
const input = AICustomizationManagementEditorInput.getOrCreate();
await this.editorService.openEditor(input, { pinned: true });
const editor = await this.editorService.openEditor(input, { pinned: true });

// Always reset to the welcome page when opening from the sidebar,
// so we don't restore the previously selected section.
if (editor instanceof AICustomizationManagementEditor) {
editor.showWelcomePage();
}
Comment thread
joshspicer marked this conversation as resolved.
}

protected override layoutBody(height: number, width: number): void {
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,7 @@ export class AICustomizationManagementEditor extends EditorPane {
/**
* Navigates to the welcome page (no section selected).
*/
private showWelcomePage(): void {
public showWelcomePage(): void {
if (this.viewMode === 'editor') {
this.goBackToList();
}
Expand Down
Loading