Fix customizations sidebar restoring previous section on reopen#311458
Open
joshspicer wants to merge 2 commits intomainfrom
Open
Fix customizations sidebar restoring previous section on reopen#311458joshspicer wants to merge 2 commits intomainfrom
joshspicer wants to merge 2 commits intomainfrom
Conversation
When clicking a sidebar category to open the Chat Customizations editor, always reset to the welcome page instead of restoring the previously selected section. This fixes the bug where clicking a different category (e.g. Hooks) after previously viewing another (e.g. Agents) would incorrectly reopen the old section. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes navigation state in the Agents app AI Customizations flow so opening the management editor from the sidebar always lands on the welcome/overview page instead of restoring the last persisted section.
Changes:
- Expose
showWelcomePage()publicly onAICustomizationManagementEditor. - After opening the management editor from the sidebar overview, explicitly reset the editor to the welcome page to clear the persisted section.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts |
Makes showWelcomePage() public so it can be invoked by external callers to clear persisted section state. |
src/vs/sessions/contrib/aiCustomizationTreeView/browser/aiCustomizationOverviewView.ts |
Calls showWelcomePage() after opening the management editor to ensure sidebar navigation always starts at the welcome page. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/bb6388b9-101e-4ded-af52-a6524bb6ed63 Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
DonJayamanne
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where clicking a sidebar category in the Agents app customizations view would restore the previously selected section instead of always opening the welcome page.
Steps to reproduce:
Fix:
showWelcomePage()public onAICustomizationManagementEditorshowWelcomePage()after opening the editor from the sidebar'sopenOverview(), so the persisted section is always cleared when navigating from the sidebar