Label memory suggestion subprocess histories as internal sessions - #16
Draft
Brian Krabach (bkrabach) wants to merge 1 commit into
Draft
Brian Krabach (bkrabach) wants to merge 1 commit into
Brian Krabach (bkrabach) wants to merge 1 commit into
Conversation
This was referenced Sep 23, 2026
Merged
Persist explicit internal session provenance across saves and resume
microsoft/amplifier-app-cli#359
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory suggestion model calls currently create ordinary CLI root histories. Mark only the suggestion subprocess as an internal
memory.suggestionsession, using a private child environment. The parent environment, argv, routing, ordinary CLI behavior, and saved histories remain unchanged.Depends on CLI provenance persistence in microsoft/amplifier-app-cli#359 and the paired Unified discovery consumer. This explicit metadata is a presentation contract; there are no prompt/title/TTY heuristics or legacy rewrites.
Validation: 51 focused suggestion tests passed (one existing conformance check excluded after reproducing its timer-display failure on untouched main); 12 relevant socket tests passed with a short macOS temporary path; changed source/tests pass Ruff and the repository frozen-contract guard. The real memory-launcher → CLI persistence → Unified discovery fixture passes with synthetic execution and no model calls. The wider suite is not green on this Mac (437 passed, 21 failures, 10 socket-path errors before the targeted short-path rerun); actual host memory save/load and production/browser acceptance remain unverified.
Paired Unified consumer: microsoft/amplifier-unified#187. Memory producer: #16. CLI producer: microsoft/amplifier-app-cli#359. This remains a reviewable three-part change; nothing has been merged or deployed by this task.