Run portable memory inference in private Core sessions - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portable memory suggestions currently launch
amplifier run, creating an ordinary conversation for a single inference. This change uses public Foundation/Core APIs to run the inference in an internal, tool-freeAmplifierSession, with generated sessions, transcripts, usage records and module caches under the existing memory home's privateruntimesubtree. Noamplifier-app-clipackage, import or executable is required.Standalone installation now declares Core ≥2.0.1, Foundation and uv. An explicit
amplifier-memory setupprepares the configured provider sources and dependencies in a new private generation. Inference never installs or activates modules. Offline readiness checks block timer installation/start/restart before mutation when the environment, configuration or prepared sources have changed. Ordinary doctor/update maintain the memory tool rather than an Amplifier CLI installation.Foundation merges shared, workspace and local settings. Named accounts and explicit provider/model choices are preserved. Role routing requires a prepared resolver configured through config.hooks; routing only supplied by bundle includes is not composed and fails visibly before a call. Explicit bundle/module composition requires host-resolved inference. Receipts distinguish response-reported and request-selected models; SDK defaults absent from both remain unknown. The dedicated console process loads missing shared credential environment values, with existing process values taking precedence; embedding APIs remain environment-neutral. Provider-owned OAuth refresh storage retains its configured ownership. Healthy model calls have no fixed completion deadline, and owned session resources are cleaned up on success, error and cancellation.
Unified's existing mounted-provider consolidation remains unchanged. This replaces the portable CLI path; it does not delete, rewrite or backfill historical sessions. Neither #16 nor microsoft/amplifier-app-cli#359 is a dependency. See
docs/PRIVATE_INFERENCE_VALIDATION.mdfor the acceptance boundary.Validation:
b224eea: missing Linuxsystemctland macOS Git manual formatting. Final focused runtime suite after the last setup guards: 18 passed.The fresh standalone proof was recorded at implementation65a6128; the exact latest correction head is10e5a25 and was checked by the ordinary focused/module/conformance runs described above. This remains a draft for review; the repository-required owner-host save/load session smoke is still unfulfilled. No real provider SDK/account/OAuth acceptance, model-quality test, real OS timer activation, component adoption or production deployment was performed. Readiness verifies installed source/configuration identity and does not claim upstream freshness or successful live authentication.