Skip to content

fix(openclaw): skip unused historical snapshot counts #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loveRhythm1990 merged 1 commit into from
Oct 22, 2026
Merged

fix(openclaw): skip unused historical snapshot counts #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion plugins/openclaw/openclaw/__tests__/snapshot-pagination.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const servers: Server[] = [];

async function serveSnapshots(total: number, mode = "normal") {
const offsets: number[] = [];
const countResolution: (string | null)[] = [];
const snapshots = Array.from({ length: total }, (_, i) => ({
name: `release_${i}`, snapshot_name: `mem_snap_release_${i}`,
timestamp: "2026-10-21T00:00:00Z",
Expand All @@ -27,6 +28,7 @@ async function serveSnapshots(total: number, mode = "normal") {
const offset = Number(url.searchParams.get("offset") ?? 0);
const limit = Number(url.searchParams.get("limit") ?? 20);
offsets.push(offset);
countResolution.push(url.searchParams.get("resolve_memory_counts"));
if (mode === "fail-later" && offset > 0) {
response.writeHead(503);
response.end("unavailable");
Expand All @@ -42,7 +44,7 @@ async function serveSnapshots(total: number, mode = "normal") {
await new Promise<void>((resolve) => server.listen(0, "127.0.0.1", resolve));
return {
apiUrl: `http://127.0.0.1:${(server.address() as AddressInfo).port}`,
offsets, snapshots,
offsets, snapshots, countResolution,
};
}

Expand All @@ -64,6 +66,8 @@ describe("snapshot discovery pagination (real HTTP)", () => {
.toEqual(fixture.snapshots.map((s) => s.name));
expect(fixture.offsets).toEqual([0, 20, 40]);
expect((await client.stats("u")).snapshotCount).toBe(45);
// Both discovery and stats need metadata, not per-snapshot historical counts.
expect(fixture.countResolution).toEqual(Array(6).fill("false"));
} finally {
client.close();
}
Expand Down Expand Up @@ -112,5 +116,6 @@ describe("snapshot discovery pagination (real HTTP)", () => {
expect(JSON.stringify(result)).toContain("release_20");
expect(JSON.stringify(result)).not.toContain("release_22");
expect(fixture.offsets).toEqual([20]);
expect(fixture.countResolution).toEqual([null]);
});
});
3 changes: 2 additions & 1 deletion plugins/openclaw/openclaw/http-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,8 @@ export class MemoriaHttpTransport {
}
const snapshots: unknown[] = [];
for (let page = 0; page < this.maxListPages; page++) {
const data = await this.get(`/v1/snapshots?limit=${limit}&offset=${offset}`);
// Discovery only uses snapshot metadata, so avoid historical count backfills.
const data = await this.get(`/v1/snapshots?limit=${limit}&offset=${offset}&resolve_memory_counts=false`);
const rec = this.asRecord(data);
if (!Array.isArray(rec?.snapshots)) {
// Preserve older unpaginated response formats on the first request.
Expand Down
Loading