Repository navigation
fix(openclaw): skip unused historical snapshot counts - #355
loveRhythm1990 merged 1 commit into
Conversation
Avoid historical count backfills during metadata-only automatic discovery. Preserve explicit page requests and verify every automatic page over real HTTP. Related to matrixorigin#354. 由 LW 授权的 ChatGPT Personal 智能体提交。
|
由 LW 授权的 ChatGPT Personal 智能体提交。 固定发布与独立复审证据:review agent 独立 fetch 远程 2a613d0,完整 tree 5563356d9e8e31c320876ebb12139f9e0afff5ca 与已实测本地 6659385bc0b067fdd9c722e2ceed1a0b50fc416e 全树 diff 为空,parent 与指定基线一致,确认署名、diff --check 并明确 Approve。两文件 +8/-2,无后续代码修订。 已实际完成 Node24.19.0 和 Node22.23.3 两套环境的插件全量234/234和打包6文件验证;独立review另执行真实HTTP回归5/5。修复前同一回归1 failed/4 passed,6个自动请求均缺少计数禁用参数。固定本地及远程提交、创建/更新本人fork独立分支、只读核验均由以上署名主体执行。Issue #354 的 XuPeng-SH assignee 已在创建响应读回;PR暂保留draft,等待完整规定CI结果后再指派并请求该负责人审阅。 |
|
由 LW 授权的 ChatGPT Personal 智能体提交。 固定head 2a613d0 的 CI 续接证据:OpenClaw #39639072851 与 PR Title Check SUCCESS;Rust/MatrixOne #39639072838 中 Check & Clippy SUCCESS,Unit Tests SUCCESS。已读取单测原始日志,116+22+45+69 = 252 passed,0 failed。DB Tests job119358340694 仍在 All tests 步骤,后续恢复/清理回归尚未执行,不能声称完整CI通过。无新review、inline thread或requested changes;未改代码、未重跑CI,继续保留draft,完整门禁通过后再执行负责人审阅交付。只读核验执行主体同上署名。 |
|
由 LW 授权的 MOI 智能体提交。 完整 CI 与交付续接证据(固定 head 2a613d0,本轮无代码修改、未重跑 CI):
|
|
LGTM. Reviewed both changed files at The issue is real: snapshot listing defaults to resolving missing historical memory counts, while OpenClaw snapshot discovery and Validation:
No correctness or regression issues found. This confirms removal of unnecessary work; no latency benchmark was performed. |
由 LW 授权的 ChatGPT Personal 智能体提交。
What type of PR is this?
Which issue(s) this PR fixes
Related to #354 and the performance suggestion on merged #352. No automatic issue closure requested.
What this PR does / why we need it
Automatic OpenClaw snapshot discovery needs names and timestamps, but its requests default to historical memory-count resolution on the server. Each uncached snapshot may trigger a historical COUNT and cache write whose result the plugin discards. With the default page budget this can touch up to 400 snapshots per scan.
Pass the existing resolve_memory_counts=false on every automatic page. Keep explicit transport limit/offset requests unchanged. The formatter/client and stats do not expose per-snapshot memory counts, so the public output stays unchanged. This is verified unnecessary database work, not a measured production latency improvement.
Verification
由 LW 授权的 ChatGPT Personal 智能体提交。