Skip to content

require transaction_data in Express sign/data docs and recipes - #136

Merged
oxyn-payward merged 1 commit into
mainfrom
WAL-165-sign-data-transaction-data
Oct 23, 2026
Merged

oxyn-payward merged 1 commit into
mainfrom
WAL-165-sign-data-transaction-data

Conversation

@oxyn-payward

Copy link
Copy Markdown
Contributor

Summary

Express sign/data now rejects an ETH raw_data_hash that isn't sent with matching transaction_data (400 INVALID_SIGNING_PARAMS). Fridge recomputes the hash from it and screens the content for sanctions. Every EVM example here sent a bare hash, so this updates them before enforcement ships. Part of WAL-165

Changes

  • express-api/wallet-operations.mdx: transaction_data is required for ETH, with the fields and hash for each method, a working eth_sign example and the 400 behavior.
  • express-api/data-preparation/evm.mdx: every signing example sends transaction_data; adds an eth_sign example and a note on unsupported transaction types (access list, blobs, authorization list).
  • express-api/policy/transaction-data.mdx: no longer says the field is only required under policy evaluation; corrects the method list and documents address for 7702.
  • Recipes (send-usdc, aave-yield, lifi-swap, morpho-yield, hyperliquid-trading, x402-payments, alchemy-smart-wallets): transactions send their fields; message and typed-data signers send the message or typed data, with the EIP-712 domain type viem hashed with.

Testing

  • Ran the new helpers' output (EIP-1559 and legacy transactions, text/hex/bytes messages, typed data with bigint and number chainId and no domain) through fridge's validator: all accepted under enforcement, with viem 2.21.55 and 2.55.19.
  • Type-checked the edited snippets in strict mode against viem 2.55.19 and ethers 6.17.
  • mint broken-links: no new broken links (the 18 existing ones are in unrelated embedded-wallet pages).

Not changed

  • The hyperliquid deposit example sets no gas or fee fields, so viem can't serialize it ("Cannot infer a transaction type"). That's a separate fix.

@oxyn-payward oxyn-payward self-assigned this Oct 22, 2026
@mintlify

mintlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
magic-labs 🟢 Ready View Preview Oct 22, 2026, 1:41 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@oxyn-payward
oxyn-payward merged commit 0ff0aa4 into main Oct 23, 2026
8 checks passed
@oxyn-payward
oxyn-payward deleted the WAL-165-sign-data-transaction-data branch October 23, 2026 15:34

This branch was successfully deployed

1 active deployment
staging — e77bc7c7 Deployed Oct 22, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants