Skip to content

document /wallet/sign as EIP-191 and drop raw_data_hash - #139

Merged
oxyn-payward merged 1 commit into
mainfrom
WAL-207-uoa-wallet-sign-eip191
Oct 27, 2026
Merged

oxyn-payward merged 1 commit into
mainfrom
WAL-207-uoa-wallet-sign-eip191

Conversation

@oxyn-payward

Copy link
Copy Markdown
Contributor

Note to Reviewers

This goes with the uoa-server's PR #76

Magic's sign/data now needs the content behind a hash, so uoa-server's /wallet/sign stops accepting a bare raw_data_hash (it returns 400). It now signs message as EIP-191 personal_sign rather than a plain keccak of the text. The UOA wallet operations page still documented the old behavior.

The Alchemy recipe change is a one-line leftover from #136. Its endpoint table still said sign/data signs "a raw hash", though the recipe's code already sends transaction_data. That part can go out any time.

Changes Made

  • Refactors the Sign Data section of uoa/api-reference/wallet-operations.mdx: message is required and signed as EIP-191, raw_data_hash is gone from the request parameters, and the response field describes the hash as the EIP-191 hash of the message
  • Refactors the sign/data row in the Alchemy smart wallets recipe's endpoint table

Testing: How do you know it works?

  • Unit Tests
  • Integration Tests
  • Local Verification
  • Deploy Preview Verification

Manual Testing Guide

The cURL example and response shape on the page are unchanged. I checked the one new claim: a signature from the new /wallet/sign verifies with ethers' verifyMessage. I signed "Hello, world!" the way uoa-server now does and verified it with ethers 6.17, which recovered the signing address.

@oxyn-payward oxyn-payward self-assigned this Oct 27, 2026
@mintlify

mintlify Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
magic-labs 🟢 Ready View Preview Oct 27, 2026, 2:38 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@oxyn-payward
oxyn-payward merged commit 02d6129 into main Oct 27, 2026
8 checks passed
@oxyn-payward
oxyn-payward deleted the WAL-207-uoa-wallet-sign-eip191 branch October 27, 2026 16:38

This branch was successfully deployed

1 active deployment
staging — 6100be9f Deployed Oct 27, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants