Repository navigation
document /wallet/sign as EIP-191 and drop raw_data_hash - #139
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
boliu-kraken
approved these changes
Oct 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note to Reviewers
This goes with the uoa-server's PR #76
Magic's sign/data now needs the content behind a hash, so uoa-server's
/wallet/signstops accepting a bareraw_data_hash(it returns 400). It now signsmessageas EIP-191 personal_sign rather than a plain keccak of the text. The UOA wallet operations page still documented the old behavior.The Alchemy recipe change is a one-line leftover from #136. Its endpoint table still said sign/data signs "a raw hash", though the recipe's code already sends
transaction_data. That part can go out any time.Changes Made
uoa/api-reference/wallet-operations.mdx:messageis required and signed as EIP-191,raw_data_hashis gone from the request parameters, and the response field describes the hash as the EIP-191 hash of the messagesign/datarow in the Alchemy smart wallets recipe's endpoint tableTesting: How do you know it works?
Manual Testing Guide
The cURL example and response shape on the page are unchanged. I checked the one new claim: a signature from the new
/wallet/signverifies with ethers'verifyMessage. I signed "Hello, world!" the way uoa-server now does and verified it with ethers 6.17, which recovered the signing address.