Repository navigation
Forward OAuth MFA login throttling events with retry details - #1139
Merged
jerry-payward merged 2 commits intoNov 11, 2026
Merged
Conversation
josh-payward
marked this pull request as ready for review
November 11, 2026 01:40
pws-kj
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Headless OAuth MFA throttling events from the iframe currently never reach integrators. Add a typed
OAuthMFAEventOnReceived.LoginThrottledevent and forward its{ retryAfterSeconds: number }payload through bothloginWithPopup()andgetRedirectResult()when the MFA modal is disabled.The existing promise handling propagates the companion wallet's RPC rejection (
-10035, withdata.retryAfterSeconds).✅ Fixed Issues
🚨 Test instructions
PKG=@magic-ext/oauth2 yarn buildpassed, including the@magic-sdk/typesand provider dependencies and declaration generation.@magic-sdk/typesand@magic-ext/oauth2on Node 22.23.4.showMfaModalfalse/true/omitted, and nonzero/zero delays. It verified event forwarding, payload identity, and propagation of the-10035rejection with retry data. This harness is not a new checked-in OAuth test suite.showMfaModal: false, observelogin-throttledwith the retry delay, and catch the rejected popup or redirect-result promise. A live OAuth login was not exercised locally.Release
Apply
minorfor the new public event. Versions are managed byautoon merge.📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @magic-ext/bitcoin@29.5.0-canary.1139.42927725889.0 npm install @magic-ext/cosmos@28.13.0-canary.1139.42927725889.0 npm install @magic-ext/evm@1.12.0-canary.1139.42927725889.0 npm install @magic-ext/farcaster@5.13.0-canary.1139.42927725889.0 npm install @magic-ext/gdkms@16.13.0-canary.1139.42927725889.0 npm install @magic-ext/hedera@2.12.0-canary.1139.42927725889.0 npm install @magic-ext/oauth2@15.15.0-canary.1139.42927725889.0 npm install @magic-ext/passkey@1.8.0-canary.1139.42927725889.0 npm install @magic-ext/react-native-bare-oauth@30.14.0-canary.1139.42927725889.0 npm install @magic-ext/react-native-expo-oauth@30.14.0-canary.1139.42927725889.0 npm install @magic-ext/siwe@3.13.0-canary.1139.42927725889.0 npm install @magic-ext/smart-account@1.8.0-canary.1139.42927725889.0 npm install @magic-ext/solana@30.13.0-canary.1139.42927725889.0 npm install @magic-ext/wallet-kit@0.18.0-canary.1139.42927725889.0 npm install @magic-ext/webauthn@27.13.0-canary.1139.42927725889.0 npm install @magic-sdk/provider@33.14.0-canary.1139.42927725889.0 npm install @magic-sdk/react-native-bare@34.13.0-canary.1139.42927725889.0 npm install @magic-sdk/react-native-expo@34.13.0-canary.1139.42927725889.0 npm install @magic-sdk/types@27.14.0-canary.1139.42927725889.0 npm install magic-sdk@33.14.0-canary.1139.42927725889.0 # or yarn add @magic-ext/bitcoin@29.5.0-canary.1139.42927725889.0 yarn add @magic-ext/cosmos@28.13.0-canary.1139.42927725889.0 yarn add @magic-ext/evm@1.12.0-canary.1139.42927725889.0 yarn add @magic-ext/farcaster@5.13.0-canary.1139.42927725889.0 yarn add @magic-ext/gdkms@16.13.0-canary.1139.42927725889.0 yarn add @magic-ext/hedera@2.12.0-canary.1139.42927725889.0 yarn add @magic-ext/oauth2@15.15.0-canary.1139.42927725889.0 yarn add @magic-ext/passkey@1.8.0-canary.1139.42927725889.0 yarn add @magic-ext/react-native-bare-oauth@30.14.0-canary.1139.42927725889.0 yarn add @magic-ext/react-native-expo-oauth@30.14.0-canary.1139.42927725889.0 yarn add @magic-ext/siwe@3.13.0-canary.1139.42927725889.0 yarn add @magic-ext/smart-account@1.8.0-canary.1139.42927725889.0 yarn add @magic-ext/solana@30.13.0-canary.1139.42927725889.0 yarn add @magic-ext/wallet-kit@0.18.0-canary.1139.42927725889.0 yarn add @magic-ext/webauthn@27.13.0-canary.1139.42927725889.0 yarn add @magic-sdk/provider@33.14.0-canary.1139.42927725889.0 yarn add @magic-sdk/react-native-bare@34.13.0-canary.1139.42927725889.0 yarn add @magic-sdk/react-native-expo@34.13.0-canary.1139.42927725889.0 yarn add @magic-sdk/types@27.14.0-canary.1139.42927725889.0 yarn add magic-sdk@33.14.0-canary.1139.42927725889.0